Skip to content

Conversation

@justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup failing-test regression

What this PR does / why we need it:

Continuation of #2003.
k8s-ci-builder: Fix CONFIG substitution for 1.21 variant

/assign @hasheddan @puerco @cpanato

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-builder: Fix `CONFIG` substitution for `1.21` variant

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2021
@puerco
Copy link
Member

puerco commented Apr 16, 2021

/lgtm

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

/test pull-release-integration-test

@justaugustus
Copy link
Member Author

The integration failure is due to a rate limit:

time="2021-04-16T02:09:39Z" level=info msg="Found latest origin/master commit 81072fcd2acd28ad2d65bcf4418fd8891ce95d51"
    changelog_test.go:106: 
        	Error Trace:	changelog_test.go:106
        	Error:      	Expected nil, but got: get latest GitHub tags: unable to retrieve GitHub tags: GET https://api.github.com/repos/kubernetes/kubernetes/tags?per_page=50: 403 API rate limit exceeded for 35.202.123.67. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 41m29s]
        	Test:       	TestNewAlphaRelease 

/override pull-release-integration-test

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Overrode contexts on behalf of justaugustus: pull-release-integration-test

In response to this:

The integration failure is due to a rate limit:

time="2021-04-16T02:09:39Z" level=info msg="Found latest origin/master commit 81072fcd2acd28ad2d65bcf4418fd8891ce95d51"
   changelog_test.go:106: 
       	Error Trace:	changelog_test.go:106
       	Error:      	Expected nil, but got: get latest GitHub tags: unable to retrieve GitHub tags: GET https://api.github.com/repos/kubernetes/kubernetes/tags?per_page=50: 403 API rate limit exceeded for 35.202.123.67. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 41m29s]
       	Test:       	TestNewAlphaRelease 

/override pull-release-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 7c1aa83 into kubernetes:master Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants