-
Notifications
You must be signed in to change notification settings - Fork 526
k8s-ci-builder: Fix CONFIG substitution for 1.21 variant
#2004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Stephen Augustus <foo@auggie.dev>
|
/lgtm |
hasheddan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-release-integration-test |
|
The integration failure is due to a rate limit: time="2021-04-16T02:09:39Z" level=info msg="Found latest origin/master commit 81072fcd2acd28ad2d65bcf4418fd8891ce95d51"
changelog_test.go:106:
Error Trace: changelog_test.go:106
Error: Expected nil, but got: get latest GitHub tags: unable to retrieve GitHub tags: GET https://api.github.com/repos/kubernetes/kubernetes/tags?per_page=50: 403 API rate limit exceeded for 35.202.123.67. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 41m29s]
Test: TestNewAlphaRelease /override pull-release-integration-test |
|
@justaugustus: Overrode contexts on behalf of justaugustus: pull-release-integration-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup failing-test regression
What this PR does / why we need it:
Continuation of #2003.
k8s-ci-builder: Fix
CONFIGsubstitution for1.21variant/assign @hasheddan @puerco @cpanato
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?