From 843bffbefe72681bb27fa532fd1aa1aa312f323f Mon Sep 17 00:00:00 2001 From: Carlos Panato Date: Sun, 14 Sep 2025 08:45:14 -0500 Subject: [PATCH] fix duplicate short hand, remove duplicated flags and mark depreated the create-website-pr Signed-off-by: Carlos Panato --- cmd/krel/cmd/release_notes.go | 4 +++- cmd/release-notes/generate.go | 14 -------------- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/cmd/krel/cmd/release_notes.go b/cmd/krel/cmd/release_notes.go index cc44bd17250..9f3c3dc622b 100644 --- a/cmd/krel/cmd/release_notes.go +++ b/cmd/krel/cmd/release_notes.go @@ -245,11 +245,13 @@ func init() { releaseNotesCmd.PersistentFlags().StringSliceVarP( &releaseNotesOpts.includeLabels, "include-labels", - "l", + "", []string{}, "only PRs with one of these labels are considered. Set to empty to include all PRs", ) + _ = releaseNotesCmd.PersistentFlags().MarkDeprecated("create-website-pr", "This flag is deprecated and will be removed in a future release. Use --create-draft-pr instead.") + rootCmd.AddCommand(releaseNotesCmd) } diff --git a/cmd/release-notes/generate.go b/cmd/release-notes/generate.go index abb683b1d07..89d7666e6a4 100644 --- a/cmd/release-notes/generate.go +++ b/cmd/release-notes/generate.go @@ -243,20 +243,6 @@ func addGenerateFlags(subcommand *cobra.Command) { []string{}, "specify a location to recursively look for release notes *.y[a]ml file mappings", ) - subcommand.PersistentFlags().BoolVar( - &opts.ListReleaseNotesV2, - "list-v2", - false, - "enable experimental implementation to list commits (ListReleaseNotesV2)", - ) - - subcommand.PersistentFlags().StringSliceVarP( - &opts.IncludeLabels, - "include-labels", - "l", - []string{}, - "Only PRs with one of these labels are considered. Set to empty to include all PRs", - ) } // addGenerate adds the generate subcomand to the main release notes cobra cmd.