Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debs: Support building arbitrary combinations of release packages #884

Merged
merged 11 commits into from Oct 9, 2019

Conversation

@justaugustus
Copy link
Member

justaugustus commented Sep 24, 2019

Given the time that has passed and things that have moved around in the repo, #734 has gotten a little too unwieldy to easily rebase, so this will supersede it.

Inspired by/required for the discussion to deprecate the kubernetes-cni package.


  • Remove usage of distro variants

    There is a fair amount of symlinking and reference to Debian/Ubuntu
    versions, which is not required (and probably hasn't been for a while).
    When building and publishing debs, we publish them to a single apt repo
    (https://packages.cloud.google.com/apt/dists/kubernetes-xenial) which
    makes no distinction between the packages within.

    This commit moves the deb package definitions to packages/latest and
    removes all symlinks. The deb build program is also slightly refactored
    here to reference the true distribution types (stable, testing, unstable).

    Future commits will divide the package definitions so we can modify the
    structure and dependencies of packages for specific versions of
    Kubernetes without affecting previous versions.

  • Simplify file structure for kubeadm package

  • Ensure debian/rules files are executable

  • Improve build logic

    • Set explicit dependency versions of CRI tools and CNI plugins
    • Allow building cri-tools and kubernetes-cni packages which
      correspond to Kubernetes versions
    • Set default package revision to "0"
    • Rename "version" struct to "packageDefinition", which is more indicative
      of the values it contains
    • Add cni-version flag to allow building arbitrary versions of kubernetes-cni
    • Remove logic for symlinking package definition directories
    • Add CNIDownloadLink to handle changes in CNI plugin download links
      between 0.7.x and 0.8.x
  • Reorganize build code
    No code changes; just moving functions around to improve readability.

  • Update package definition locations in Dockerfile

  • Enable building arbitrary packages, distributions, versions

  • Add support for specifying CRI tools version

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 24, 2019

@justaugustus: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from ps882 and sumitranr Sep 24, 2019
@justaugustus justaugustus force-pushed the justaugustus:deb-refactor branch from a1d0469 to 9206c11 Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels Sep 26, 2019
@justaugustus justaugustus force-pushed the justaugustus:deb-refactor branch from 9206c11 to cd5e1a9 Sep 26, 2019
@justaugustus justaugustus changed the title [WIP] debs: Support per Kubernetes release package definitions debs: Support per Kubernetes release package definitions Sep 26, 2019
@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Sep 26, 2019

There are still tweaks I want to do for this (improving log output, error messages, refactor a few functions) before adding the per-release package logic, but this is a good time to get an initial review.

@kubernetes/release-engineering @kubernetes/build-admins
/assign @tpepper @hoegaarden

Here's some example output from a build run:

time go run build.go -arch amd64 -cni-version 0.8.2:

2019/09/26 09:33:21 download link base is 
2019/09/26 09:33:21 download link base is https://dl.k8s.io/v1.16.0
2019/09/26 09:33:21 package name is kubectl
2019/09/26 09:33:21 using Kubernetes version
2019/09/26 09:33:21 package version is 1.16.0
2019/09/26 09:33:21 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0000f4000), Arch:"amd64", DebArch:"amd64", Package:"kubectl", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:33:21 /tmp/debs019118824/debian
2019/09/26 09:33:21 /tmp/debs019118824/debian/source
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/changelog", dst:"/tmp/debs019118824/debian/changelog", t:(*template.Template)(0xc000070a80), info:(*os.fileStat)(0xc000306340)}
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/compat", dst:"/tmp/debs019118824/debian/compat", t:(*template.Template)(0xc000070bc0), info:(*os.fileStat)(0xc000306680)}
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/control", dst:"/tmp/debs019118824/debian/control", t:(*template.Template)(0xc000070c80), info:(*os.fileStat)(0xc0003069c0)}
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/copyright", dst:"/tmp/debs019118824/debian/copyright", t:(*template.Template)(0xc000070d80), info:(*os.fileStat)(0xc000306d00)}
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/kubectl.install", dst:"/tmp/debs019118824/debian/kubectl.install", t:(*template.Template)(0xc000070e40), info:(*os.fileStat)(0xc000307040)}
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/postinst", dst:"/tmp/debs019118824/debian/postinst", t:(*template.Template)(0xc000070f00), info:(*os.fileStat)(0xc000307380)}
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/rules", dst:"/tmp/debs019118824/debian/rules", t:(*template.Template)(0xc000070fc0), info:(*os.fileStat)(0xc0003076c0)}
2019/09/26 09:33:21 w: main.work{src:"packages/latest/kubectl/debian/source/format", dst:"/tmp/debs019118824/debian/source/format", t:(*template.Template)(0xc0000710c0), info:(*os.fileStat)(0xc000307ad0)}
dpkg-buildpackage: info: source package kubectl
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs019118824
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl  --fail -sS -L --retry 5 \
	-o usr/bin/kubectl \
	"https://dl.k8s.io/v1.16.0/bin/linux/amd64/kubectl"
chmod +x usr/bin/kubectl
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubectl' in '../kubectl_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubectl_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs019118824
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:33:37 download link base is 
2019/09/26 09:33:37 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/26 09:33:37 package name is kubectl
2019/09/26 09:33:37 using Kubernetes version
2019/09/26 09:33:37 package version is 1.17.0-alpha.0
2019/09/26 09:33:37 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000356360), Arch:"amd64", DebArch:"amd64", Package:"kubectl", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:33:37 /tmp/debs361726759/debian
2019/09/26 09:33:37 /tmp/debs361726759/debian/source
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/changelog", dst:"/tmp/debs361726759/debian/changelog", t:(*template.Template)(0xc000071540), info:(*os.fileStat)(0xc00051d2b0)}
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/compat", dst:"/tmp/debs361726759/debian/compat", t:(*template.Template)(0xc000071680), info:(*os.fileStat)(0xc00051d5f0)}
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/control", dst:"/tmp/debs361726759/debian/control", t:(*template.Template)(0xc000071740), info:(*os.fileStat)(0xc00051d930)}
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/copyright", dst:"/tmp/debs361726759/debian/copyright", t:(*template.Template)(0xc000071840), info:(*os.fileStat)(0xc00051dc70)}
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/kubectl.install", dst:"/tmp/debs361726759/debian/kubectl.install", t:(*template.Template)(0xc000071900), info:(*os.fileStat)(0xc0004fe000)}
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/postinst", dst:"/tmp/debs361726759/debian/postinst", t:(*template.Template)(0xc0000719c0), info:(*os.fileStat)(0xc0004fe340)}
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/rules", dst:"/tmp/debs361726759/debian/rules", t:(*template.Template)(0xc000071a80), info:(*os.fileStat)(0xc0004fe680)}
2019/09/26 09:33:37 w: main.work{src:"packages/latest/kubectl/debian/source/format", dst:"/tmp/debs361726759/debian/source/format", t:(*template.Template)(0xc000071b80), info:(*os.fileStat)(0xc0004fea90)}
dpkg-buildpackage: info: source package kubectl
dpkg-buildpackage: info: source version 1.17.0-alpha.0-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs361726759
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl  --fail -sS -L --retry 5 \
	-o usr/bin/kubectl \
	"https://dl.k8s.io/v1.17.0-alpha.0/bin/linux/amd64/kubectl"
chmod +x usr/bin/kubectl
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubectl' in '../kubectl_1.17.0-alpha.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubectl_1.17.0-alpha.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs361726759
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:33:52 download link base is 
2019/09/26 09:33:52 download link base is https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da
2019/09/26 09:33:52 package name is kubectl
2019/09/26 09:33:52 using Kubernetes version
2019/09/26 09:33:52 package version is 1.17.0-alpha.0.1832-d8a420c0d810da
2019/09/26 09:33:52 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0003566c0), Arch:"amd64", DebArch:"amd64", Package:"kubectl", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:33:52 /tmp/debs580671578/debian
2019/09/26 09:33:52 /tmp/debs580671578/debian/source
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/changelog", dst:"/tmp/debs580671578/debian/changelog", t:(*template.Template)(0xc000576000), info:(*os.fileStat)(0xc0005701a0)}
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/compat", dst:"/tmp/debs580671578/debian/compat", t:(*template.Template)(0xc000576140), info:(*os.fileStat)(0xc0005704e0)}
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/control", dst:"/tmp/debs580671578/debian/control", t:(*template.Template)(0xc000576200), info:(*os.fileStat)(0xc000570820)}
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/copyright", dst:"/tmp/debs580671578/debian/copyright", t:(*template.Template)(0xc000576300), info:(*os.fileStat)(0xc000570b60)}
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/kubectl.install", dst:"/tmp/debs580671578/debian/kubectl.install", t:(*template.Template)(0xc0005763c0), info:(*os.fileStat)(0xc000570ea0)}
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/postinst", dst:"/tmp/debs580671578/debian/postinst", t:(*template.Template)(0xc000576480), info:(*os.fileStat)(0xc0005711e0)}
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/rules", dst:"/tmp/debs580671578/debian/rules", t:(*template.Template)(0xc000576540), info:(*os.fileStat)(0xc000571520)}
2019/09/26 09:33:52 w: main.work{src:"packages/latest/kubectl/debian/source/format", dst:"/tmp/debs580671578/debian/source/format", t:(*template.Template)(0xc00058a100), info:(*os.fileStat)(0xc000592270)}
dpkg-buildpackage: info: source package kubectl
dpkg-buildpackage: info: source version 1.17.0-alpha.0.1832-d8a420c0d810da-0
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs580671578
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl  --fail -sS -L --retry 5 \
	-o usr/bin/kubectl \
	"https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da/bin/linux/amd64/kubectl"
chmod +x usr/bin/kubectl
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubectl' in '../kubectl_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubectl_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs580671578
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:34:06 download link base is 
2019/09/26 09:34:06 download link base is https://dl.k8s.io/v1.16.0
2019/09/26 09:34:06 package name is kubelet
2019/09/26 09:34:06 using Kubernetes version
2019/09/26 09:34:06 package version is 1.16.0
2019/09/26 09:34:06 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000356240), Arch:"amd64", DebArch:"amd64", Package:"kubelet", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:34:06 /tmp/debs306016753/debian
2019/09/26 09:34:06 /tmp/debs306016753/debian/source
2019/09/26 09:34:06 /tmp/debs306016753/lib
2019/09/26 09:34:06 /tmp/debs306016753/lib/systemd
2019/09/26 09:34:06 /tmp/debs306016753/lib/systemd/system
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/changelog", dst:"/tmp/debs306016753/debian/changelog", t:(*template.Template)(0xc00058a600), info:(*os.fileStat)(0xc000593ad0)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/compat", dst:"/tmp/debs306016753/debian/compat", t:(*template.Template)(0xc00058a740), info:(*os.fileStat)(0xc000593e10)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/control", dst:"/tmp/debs306016753/debian/control", t:(*template.Template)(0xc00058a800), info:(*os.fileStat)(0xc0000988f0)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/copyright", dst:"/tmp/debs306016753/debian/copyright", t:(*template.Template)(0xc00058a900), info:(*os.fileStat)(0xc0000991e0)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/kubelet.install", dst:"/tmp/debs306016753/debian/kubelet.install", t:(*template.Template)(0xc00058a9c0), info:(*os.fileStat)(0xc000099520)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/postinst", dst:"/tmp/debs306016753/debian/postinst", t:(*template.Template)(0xc00058aa80), info:(*os.fileStat)(0xc000099860)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/rules", dst:"/tmp/debs306016753/debian/rules", t:(*template.Template)(0xc00058ab40), info:(*os.fileStat)(0xc000099ba0)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/debian/source/format", dst:"/tmp/debs306016753/debian/source/format", t:(*template.Template)(0xc00058ac40), info:(*os.fileStat)(0xc000306000)}
2019/09/26 09:34:06 w: main.work{src:"packages/latest/kubelet/lib/systemd/system/kubelet.service", dst:"/tmp/debs306016753/lib/systemd/system/kubelet.service", t:(*template.Template)(0xc00058ad00), info:(*os.fileStat)(0xc000306680)}
dpkg-buildpackage: info: source package kubelet
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs306016753
 fakeroot debian/rules clean
dh clean --with systemd
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl  --fail -sS -L --retry 5 \
	-o usr/bin/kubelet \
	"https://dl.k8s.io/v1.16.0/bin/linux/amd64/kubelet"
chmod +x usr/bin/kubelet
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_systemd_enable
dh_installinit
dh_systemd_start
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubelet' in '../kubelet_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubelet_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs306016753
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:34:26 download link base is 
2019/09/26 09:34:26 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/26 09:34:26 package name is kubelet
2019/09/26 09:34:26 using Kubernetes version
2019/09/26 09:34:26 package version is 1.17.0-alpha.0
2019/09/26 09:34:26 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000356750), Arch:"amd64", DebArch:"amd64", Package:"kubelet", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:34:26 /tmp/debs226855068/debian
2019/09/26 09:34:26 /tmp/debs226855068/debian/source
2019/09/26 09:34:26 /tmp/debs226855068/lib
2019/09/26 09:34:26 /tmp/debs226855068/lib/systemd
2019/09/26 09:34:26 /tmp/debs226855068/lib/systemd/system
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/changelog", dst:"/tmp/debs226855068/debian/changelog", t:(*template.Template)(0xc00058b1c0), info:(*os.fileStat)(0xc000307c70)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/compat", dst:"/tmp/debs226855068/debian/compat", t:(*template.Template)(0xc00058b300), info:(*os.fileStat)(0xc000570270)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/control", dst:"/tmp/debs226855068/debian/control", t:(*template.Template)(0xc00058b3c0), info:(*os.fileStat)(0xc0005708f0)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/copyright", dst:"/tmp/debs226855068/debian/copyright", t:(*template.Template)(0xc00058b4c0), info:(*os.fileStat)(0xc000570f70)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/kubelet.install", dst:"/tmp/debs226855068/debian/kubelet.install", t:(*template.Template)(0xc00058b580), info:(*os.fileStat)(0xc000571860)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/postinst", dst:"/tmp/debs226855068/debian/postinst", t:(*template.Template)(0xc00058b640), info:(*os.fileStat)(0xc000571ba0)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/rules", dst:"/tmp/debs226855068/debian/rules", t:(*template.Template)(0xc00058b700), info:(*os.fileStat)(0xc000571ee0)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/debian/source/format", dst:"/tmp/debs226855068/debian/source/format", t:(*template.Template)(0xc00058b800), info:(*os.fileStat)(0xc0002aa410)}
2019/09/26 09:34:26 w: main.work{src:"packages/latest/kubelet/lib/systemd/system/kubelet.service", dst:"/tmp/debs226855068/lib/systemd/system/kubelet.service", t:(*template.Template)(0xc00058b8c0), info:(*os.fileStat)(0xc0002aa9c0)}
dpkg-buildpackage: info: source package kubelet
dpkg-buildpackage: info: source version 1.17.0-alpha.0-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs226855068
 fakeroot debian/rules clean
dh clean --with systemd
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl  --fail -sS -L --retry 5 \
	-o usr/bin/kubelet \
	"https://dl.k8s.io/v1.17.0-alpha.0/bin/linux/amd64/kubelet"
chmod +x usr/bin/kubelet
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_systemd_enable
dh_installinit
dh_systemd_start
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubelet' in '../kubelet_1.17.0-alpha.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubelet_1.17.0-alpha.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs226855068
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:34:45 download link base is 
2019/09/26 09:34:45 download link base is https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da
2019/09/26 09:34:45 package name is kubelet
2019/09/26 09:34:45 using Kubernetes version
2019/09/26 09:34:45 package version is 1.17.0-alpha.0.1832-d8a420c0d810da
2019/09/26 09:34:45 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000356b40), Arch:"amd64", DebArch:"amd64", Package:"kubelet", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:34:45 /tmp/debs011237195/debian
2019/09/26 09:34:45 /tmp/debs011237195/debian/source
2019/09/26 09:34:45 /tmp/debs011237195/lib
2019/09/26 09:34:45 /tmp/debs011237195/lib/systemd
2019/09/26 09:34:45 /tmp/debs011237195/lib/systemd/system
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/changelog", dst:"/tmp/debs011237195/debian/changelog", t:(*template.Template)(0xc00058be00), info:(*os.fileStat)(0xc000138000)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/compat", dst:"/tmp/debs011237195/debian/compat", t:(*template.Template)(0xc00058bf40), info:(*os.fileStat)(0xc000138340)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/control", dst:"/tmp/debs011237195/debian/control", t:(*template.Template)(0xc000576040), info:(*os.fileStat)(0xc000138680)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/copyright", dst:"/tmp/debs011237195/debian/copyright", t:(*template.Template)(0xc000576280), info:(*os.fileStat)(0xc0001389c0)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/kubelet.install", dst:"/tmp/debs011237195/debian/kubelet.install", t:(*template.Template)(0xc0005765c0), info:(*os.fileStat)(0xc000138f70)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/postinst", dst:"/tmp/debs011237195/debian/postinst", t:(*template.Template)(0xc000576680), info:(*os.fileStat)(0xc0001392b0)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/rules", dst:"/tmp/debs011237195/debian/rules", t:(*template.Template)(0xc000576740), info:(*os.fileStat)(0xc0001395f0)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/debian/source/format", dst:"/tmp/debs011237195/debian/source/format", t:(*template.Template)(0xc000576840), info:(*os.fileStat)(0xc000139a00)}
2019/09/26 09:34:45 w: main.work{src:"packages/latest/kubelet/lib/systemd/system/kubelet.service", dst:"/tmp/debs011237195/lib/systemd/system/kubelet.service", t:(*template.Template)(0xc000576900), info:(*os.fileStat)(0xc0003ec000)}
dpkg-buildpackage: info: source package kubelet
dpkg-buildpackage: info: source version 1.17.0-alpha.0.1832-d8a420c0d810da-0
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs011237195
 fakeroot debian/rules clean
dh clean --with systemd
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl  --fail -sS -L --retry 5 \
	-o usr/bin/kubelet \
	"https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da/bin/linux/amd64/kubelet"
chmod +x usr/bin/kubelet
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_systemd_enable
dh_installinit
dh_systemd_start
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubelet' in '../kubelet_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubelet_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs011237195
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:35:07 download link base is 
2019/09/26 09:35:07 download link base is https://dl.k8s.io/v1.16.0
2019/09/26 09:35:07 package name is kubernetes-cni
2019/09/26 09:35:07 using CNI version
2019/09/26 09:35:07 checking kube version (1.16.0) against 1.17.0-alpha.0
2019/09/26 09:35:07 package version is 0.7.5
2019/09/26 09:35:07 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000356fc0), Arch:"amd64", DebArch:"amd64", Package:"kubernetes-cni", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:35:07 /tmp/debs397371438/debian
2019/09/26 09:35:07 w: main.work{src:"packages/latest/kubernetes-cni/.gitignore", dst:"/tmp/debs397371438/.gitignore", t:(*template.Template)(0xc000576dc0), info:(*os.fileStat)(0xc0003ed450)}
2019/09/26 09:35:07 w: main.work{src:"packages/latest/kubernetes-cni/debian/changelog", dst:"/tmp/debs397371438/debian/changelog", t:(*template.Template)(0xc000576ec0), info:(*os.fileStat)(0xc0003ed860)}
2019/09/26 09:35:07 w: main.work{src:"packages/latest/kubernetes-cni/debian/compat", dst:"/tmp/debs397371438/debian/compat", t:(*template.Template)(0xc000576fc0), info:(*os.fileStat)(0xc0003edba0)}
2019/09/26 09:35:07 w: main.work{src:"packages/latest/kubernetes-cni/debian/control", dst:"/tmp/debs397371438/debian/control", t:(*template.Template)(0xc000577080), info:(*os.fileStat)(0xc0003edee0)}
2019/09/26 09:35:07 w: main.work{src:"packages/latest/kubernetes-cni/debian/copyright", dst:"/tmp/debs397371438/debian/copyright", t:(*template.Template)(0xc000577180), info:(*os.fileStat)(0xc0005d0270)}
2019/09/26 09:35:07 w: main.work{src:"packages/latest/kubernetes-cni/debian/kubernetes-cni.install", dst:"/tmp/debs397371438/debian/kubernetes-cni.install", t:(*template.Template)(0xc000577240), info:(*os.fileStat)(0xc0005d05b0)}
2019/09/26 09:35:07 w: main.work{src:"packages/latest/kubernetes-cni/debian/rules", dst:"/tmp/debs397371438/debian/rules", t:(*template.Template)(0xc000577300), info:(*os.fileStat)(0xc0005d08f0)}
dpkg-buildpackage: info: source package kubernetes-cni
dpkg-buildpackage: info: source version 0.7.5-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs397371438
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/containernetworking/plugins/releases/download/v0.7.5/cni-plugins-amd64-v0.7.5.tgz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package kubernetes-cni: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubernetes-cni' in '../kubernetes-cni_0.7.5-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubernetes-cni_0.7.5-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs397371438
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:35:19 download link base is 
2019/09/26 09:35:19 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/26 09:35:19 package name is kubernetes-cni
2019/09/26 09:35:19 using CNI version
2019/09/26 09:35:19 checking kube version (1.17.0-alpha.0) against 1.17.0-alpha.0
2019/09/26 09:35:19 package version is 0.8.2
2019/09/26 09:35:19 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0000f4000), Arch:"amd64", DebArch:"amd64", Package:"kubernetes-cni", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:35:19 /tmp/debs153222581/debian
2019/09/26 09:35:19 w: main.work{src:"packages/latest/kubernetes-cni/.gitignore", dst:"/tmp/debs153222581/.gitignore", t:(*template.Template)(0xc000070900), info:(*os.fileStat)(0xc0001380d0)}
2019/09/26 09:35:19 w: main.work{src:"packages/latest/kubernetes-cni/debian/changelog", dst:"/tmp/debs153222581/debian/changelog", t:(*template.Template)(0xc000070a80), info:(*os.fileStat)(0xc0001384e0)}
2019/09/26 09:35:19 w: main.work{src:"packages/latest/kubernetes-cni/debian/compat", dst:"/tmp/debs153222581/debian/compat", t:(*template.Template)(0xc000070b80), info:(*os.fileStat)(0xc000138820)}
2019/09/26 09:35:19 w: main.work{src:"packages/latest/kubernetes-cni/debian/control", dst:"/tmp/debs153222581/debian/control", t:(*template.Template)(0xc000070c40), info:(*os.fileStat)(0xc000138b60)}
2019/09/26 09:35:19 w: main.work{src:"packages/latest/kubernetes-cni/debian/copyright", dst:"/tmp/debs153222581/debian/copyright", t:(*template.Template)(0xc000070d40), info:(*os.fileStat)(0xc000139110)}
2019/09/26 09:35:19 w: main.work{src:"packages/latest/kubernetes-cni/debian/kubernetes-cni.install", dst:"/tmp/debs153222581/debian/kubernetes-cni.install", t:(*template.Template)(0xc000070e00), info:(*os.fileStat)(0xc000139450)}
2019/09/26 09:35:19 w: main.work{src:"packages/latest/kubernetes-cni/debian/rules", dst:"/tmp/debs153222581/debian/rules", t:(*template.Template)(0xc000070ec0), info:(*os.fileStat)(0xc000139790)}
dpkg-buildpackage: info: source package kubernetes-cni
dpkg-buildpackage: info: source version 0.8.2-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs153222581
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/containernetworking/plugins/releases/download/v0.8.2/cni-plugins-linux-amd64-v0.8.2.tgz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package kubernetes-cni: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubernetes-cni' in '../kubernetes-cni_0.8.2-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubernetes-cni_0.8.2-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs153222581
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:35:33 download link base is 
2019/09/26 09:35:33 download link base is https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da
2019/09/26 09:35:33 package name is kubernetes-cni
2019/09/26 09:35:33 using CNI version
2019/09/26 09:35:33 checking kube version (1.17.0-alpha.0.1832-d8a420c0d810da) against 1.17.0-alpha.0
2019/09/26 09:35:33 package version is 0.8.2
2019/09/26 09:35:33 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0001342d0), Arch:"amd64", DebArch:"amd64", Package:"kubernetes-cni", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:35:33 /tmp/debs751573392/debian
2019/09/26 09:35:33 w: main.work{src:"packages/latest/kubernetes-cni/.gitignore", dst:"/tmp/debs751573392/.gitignore", t:(*template.Template)(0xc000071380), info:(*os.fileStat)(0xc0002aadd0)}
2019/09/26 09:35:33 w: main.work{src:"packages/latest/kubernetes-cni/debian/changelog", dst:"/tmp/debs751573392/debian/changelog", t:(*template.Template)(0xc000071480), info:(*os.fileStat)(0xc0002ab1e0)}
2019/09/26 09:35:33 w: main.work{src:"packages/latest/kubernetes-cni/debian/compat", dst:"/tmp/debs751573392/debian/compat", t:(*template.Template)(0xc000071580), info:(*os.fileStat)(0xc0002ab520)}
2019/09/26 09:35:33 w: main.work{src:"packages/latest/kubernetes-cni/debian/control", dst:"/tmp/debs751573392/debian/control", t:(*template.Template)(0xc000071640), info:(*os.fileStat)(0xc0002ab860)}
2019/09/26 09:35:33 w: main.work{src:"packages/latest/kubernetes-cni/debian/copyright", dst:"/tmp/debs751573392/debian/copyright", t:(*template.Template)(0xc000071740), info:(*os.fileStat)(0xc0002abba0)}
2019/09/26 09:35:33 w: main.work{src:"packages/latest/kubernetes-cni/debian/kubernetes-cni.install", dst:"/tmp/debs751573392/debian/kubernetes-cni.install", t:(*template.Template)(0xc000071800), info:(*os.fileStat)(0xc0002abee0)}
2019/09/26 09:35:33 w: main.work{src:"packages/latest/kubernetes-cni/debian/rules", dst:"/tmp/debs751573392/debian/rules", t:(*template.Template)(0xc0000718c0), info:(*os.fileStat)(0xc000306340)}
dpkg-buildpackage: info: source package kubernetes-cni
dpkg-buildpackage: info: source version 0.8.2-0
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs751573392
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/containernetworking/plugins/releases/download/v0.8.2/cni-plugins-linux-amd64-v0.8.2.tgz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package kubernetes-cni: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubernetes-cni' in '../kubernetes-cni_0.8.2-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubernetes-cni_0.8.2-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs751573392
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:35:46 download link base is 
2019/09/26 09:35:46 download link base is https://dl.k8s.io/v1.16.0
2019/09/26 09:35:46 package name is kubeadm
2019/09/26 09:35:46 using Kubernetes version
2019/09/26 09:35:46 package version is 1.16.0
2019/09/26 09:35:46 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000134630), Arch:"amd64", DebArch:"amd64", Package:"kubeadm", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:35:46 /tmp/debs618582447/debian
2019/09/26 09:35:46 /tmp/debs618582447/debian/source
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/10-kubeadm.conf", dst:"/tmp/debs618582447/10-kubeadm.conf", t:(*template.Template)(0xc000071d80), info:(*os.fileStat)(0xc000307860)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/changelog", dst:"/tmp/debs618582447/debian/changelog", t:(*template.Template)(0xc000071e80), info:(*os.fileStat)(0xc000307c70)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/compat", dst:"/tmp/debs618582447/debian/compat", t:(*template.Template)(0xc000071f80), info:(*os.fileStat)(0xc000098820)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/control", dst:"/tmp/debs618582447/debian/control", t:(*template.Template)(0xc0002bc040), info:(*os.fileStat)(0xc000099110)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/copyright", dst:"/tmp/debs618582447/debian/copyright", t:(*template.Template)(0xc0002bc140), info:(*os.fileStat)(0xc000099450)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/kubeadm.install", dst:"/tmp/debs618582447/debian/kubeadm.install", t:(*template.Template)(0xc0002bc200), info:(*os.fileStat)(0xc000099790)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/postinst", dst:"/tmp/debs618582447/debian/postinst", t:(*template.Template)(0xc0002bc300), info:(*os.fileStat)(0xc000099ad0)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/rules", dst:"/tmp/debs618582447/debian/rules", t:(*template.Template)(0xc0002bc3c0), info:(*os.fileStat)(0xc000099e10)}
2019/09/26 09:35:46 w: main.work{src:"packages/latest/kubeadm/debian/source/format", dst:"/tmp/debs618582447/debian/source/format", t:(*template.Template)(0xc0002bc4c0), info:(*os.fileStat)(0xc0004b4270)}
dpkg-buildpackage: info: source package kubeadm
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs618582447
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl --fail -sSL --retry 5 \
	-o usr/bin/kubeadm \
	"https://dl.k8s.io/v1.16.0/bin/linux/amd64/kubeadm"
chmod +x usr/bin/kubeadm
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubeadm' in '../kubeadm_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubeadm_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs618582447
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:36:01 download link base is 
2019/09/26 09:36:01 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/26 09:36:01 package name is kubeadm
2019/09/26 09:36:01 using Kubernetes version
2019/09/26 09:36:01 package version is 1.17.0-alpha.0
2019/09/26 09:36:01 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000134ab0), Arch:"amd64", DebArch:"amd64", Package:"kubeadm", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:36:01 /tmp/debs940758850/debian
2019/09/26 09:36:01 /tmp/debs940758850/debian/source
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/10-kubeadm.conf", dst:"/tmp/debs940758850/10-kubeadm.conf", t:(*template.Template)(0xc000158240), info:(*os.fileStat)(0xc0005ea0d0)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/changelog", dst:"/tmp/debs940758850/debian/changelog", t:(*template.Template)(0xc000158340), info:(*os.fileStat)(0xc0005ea4e0)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/compat", dst:"/tmp/debs940758850/debian/compat", t:(*template.Template)(0xc000158440), info:(*os.fileStat)(0xc0005ea820)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/control", dst:"/tmp/debs940758850/debian/control", t:(*template.Template)(0xc000158500), info:(*os.fileStat)(0xc0005eab60)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/copyright", dst:"/tmp/debs940758850/debian/copyright", t:(*template.Template)(0xc000158700), info:(*os.fileStat)(0xc0005eaea0)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/kubeadm.install", dst:"/tmp/debs940758850/debian/kubeadm.install", t:(*template.Template)(0xc0001587c0), info:(*os.fileStat)(0xc0005eb1e0)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/postinst", dst:"/tmp/debs940758850/debian/postinst", t:(*template.Template)(0xc0001588c0), info:(*os.fileStat)(0xc0005eb520)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/rules", dst:"/tmp/debs940758850/debian/rules", t:(*template.Template)(0xc000158980), info:(*os.fileStat)(0xc0005eb860)}
2019/09/26 09:36:01 w: main.work{src:"packages/latest/kubeadm/debian/source/format", dst:"/tmp/debs940758850/debian/source/format", t:(*template.Template)(0xc000158a80), info:(*os.fileStat)(0xc0005ebc70)}
dpkg-buildpackage: info: source package kubeadm
dpkg-buildpackage: info: source version 1.17.0-alpha.0-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs940758850
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl --fail -sSL --retry 5 \
	-o usr/bin/kubeadm \
	"https://dl.k8s.io/v1.17.0-alpha.0/bin/linux/amd64/kubeadm"
chmod +x usr/bin/kubeadm
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubeadm' in '../kubeadm_1.17.0-alpha.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubeadm_1.17.0-alpha.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs940758850
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:36:29 download link base is 
2019/09/26 09:36:29 download link base is https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da
2019/09/26 09:36:29 package name is kubeadm
2019/09/26 09:36:29 using Kubernetes version
2019/09/26 09:36:29 package version is 1.17.0-alpha.0.1832-d8a420c0d810da
2019/09/26 09:36:29 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000350360), Arch:"amd64", DebArch:"amd64", Package:"kubeadm", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:36:29 /tmp/debs627349945/debian
2019/09/26 09:36:29 /tmp/debs627349945/debian/source
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/10-kubeadm.conf", dst:"/tmp/debs627349945/10-kubeadm.conf", t:(*template.Template)(0xc0002bca80), info:(*os.fileStat)(0xc0004b5a00)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/changelog", dst:"/tmp/debs627349945/debian/changelog", t:(*template.Template)(0xc0002bcb80), info:(*os.fileStat)(0xc0004b5e10)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/compat", dst:"/tmp/debs627349945/debian/compat", t:(*template.Template)(0xc0002bcc80), info:(*os.fileStat)(0xc0005741a0)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/control", dst:"/tmp/debs627349945/debian/control", t:(*template.Template)(0xc0002bcd40), info:(*os.fileStat)(0xc0005744e0)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/copyright", dst:"/tmp/debs627349945/debian/copyright", t:(*template.Template)(0xc0002bce40), info:(*os.fileStat)(0xc000574820)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/kubeadm.install", dst:"/tmp/debs627349945/debian/kubeadm.install", t:(*template.Template)(0xc0002bcf00), info:(*os.fileStat)(0xc000574b60)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/postinst", dst:"/tmp/debs627349945/debian/postinst", t:(*template.Template)(0xc0002bd000), info:(*os.fileStat)(0xc000574ea0)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/rules", dst:"/tmp/debs627349945/debian/rules", t:(*template.Template)(0xc0002bd0c0), info:(*os.fileStat)(0xc0005751e0)}
2019/09/26 09:36:29 w: main.work{src:"packages/latest/kubeadm/debian/source/format", dst:"/tmp/debs627349945/debian/source/format", t:(*template.Template)(0xc0002bd1c0), info:(*os.fileStat)(0xc0005755f0)}
dpkg-buildpackage: info: source package kubeadm
dpkg-buildpackage: info: source version 1.17.0-alpha.0.1832-d8a420c0d810da-0
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs627349945
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl --fail -sSL --retry 5 \
	-o usr/bin/kubeadm \
	"https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da/bin/linux/amd64/kubeadm"
chmod +x usr/bin/kubeadm
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubeadm' in '../kubeadm_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubeadm_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs627349945
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:36:43 download link base is 
2019/09/26 09:36:43 download link base is https://dl.k8s.io/v1.16.0
2019/09/26 09:36:43 package name is cri-tools
2019/09/26 09:36:43 CRI tools function
2019/09/26 09:36:43 using CRI version
2019/09/26 09:36:43 [1 16 0], len: 3
2019/09/26 09:36:43 package version is 1.16.0
2019/09/26 09:36:43 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0000f4000), Arch:"amd64", DebArch:"amd64", Package:"cri-tools", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:36:43 /tmp/debs361495492/debian
2019/09/26 09:36:43 w: main.work{src:"packages/latest/cri-tools/debian/changelog", dst:"/tmp/debs361495492/debian/changelog", t:(*template.Template)(0xc0002bc080), info:(*os.fileStat)(0xc0000988f0)}
2019/09/26 09:36:43 w: main.work{src:"packages/latest/cri-tools/debian/compat", dst:"/tmp/debs361495492/debian/compat", t:(*template.Template)(0xc0002bc1c0), info:(*os.fileStat)(0xc0000991e0)}
2019/09/26 09:36:43 w: main.work{src:"packages/latest/cri-tools/debian/control", dst:"/tmp/debs361495492/debian/control", t:(*template.Template)(0xc0002bc280), info:(*os.fileStat)(0xc000099520)}
2019/09/26 09:36:43 w: main.work{src:"packages/latest/cri-tools/debian/copyright", dst:"/tmp/debs361495492/debian/copyright", t:(*template.Template)(0xc0002bc380), info:(*os.fileStat)(0xc000099860)}
2019/09/26 09:36:43 w: main.work{src:"packages/latest/cri-tools/debian/cri-tools.install", dst:"/tmp/debs361495492/debian/cri-tools.install", t:(*template.Template)(0xc0002bc440), info:(*os.fileStat)(0xc000099ba0)}
2019/09/26 09:36:43 w: main.work{src:"packages/latest/cri-tools/debian/rules", dst:"/tmp/debs361495492/debian/rules", t:(*template.Template)(0xc0002bc500), info:(*os.fileStat)(0xc000099ee0)}
dpkg-buildpackage: info: source package cri-tools
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs361495492
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.16.0/crictl-v1.16.0-linux-amd64.tar.gz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package cri-tools: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'cri-tools' in '../cri-tools_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../cri-tools_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs361495492
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:36:54 download link base is 
2019/09/26 09:36:54 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/26 09:36:54 package name is cri-tools
2019/09/26 09:36:54 CRI tools function
2019/09/26 09:36:54 using CRI version
2019/09/26 09:36:54 [1 17 0-alpha 0], len: 4
2019/09/26 09:36:54 CRI minor is 17
2019/09/26 09:36:54 CRI minor is 16
2019/09/26 09:36:54 package version is 1.16.0
2019/09/26 09:36:54 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0002e62d0), Arch:"amd64", DebArch:"amd64", Package:"cri-tools", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:36:54 /tmp/debs969490515/debian
2019/09/26 09:36:54 w: main.work{src:"packages/latest/cri-tools/debian/changelog", dst:"/tmp/debs969490515/debian/changelog", t:(*template.Template)(0xc000070b00), info:(*os.fileStat)(0xc0002aa270)}
2019/09/26 09:36:54 w: main.work{src:"packages/latest/cri-tools/debian/compat", dst:"/tmp/debs969490515/debian/compat", t:(*template.Template)(0xc000070c40), info:(*os.fileStat)(0xc0002aa5b0)}
2019/09/26 09:36:54 w: main.work{src:"packages/latest/cri-tools/debian/control", dst:"/tmp/debs969490515/debian/control", t:(*template.Template)(0xc000070d00), info:(*os.fileStat)(0xc0002aa8f0)}
2019/09/26 09:36:54 w: main.work{src:"packages/latest/cri-tools/debian/copyright", dst:"/tmp/debs969490515/debian/copyright", t:(*template.Template)(0xc000070e00), info:(*os.fileStat)(0xc0002aac30)}
2019/09/26 09:36:54 w: main.work{src:"packages/latest/cri-tools/debian/cri-tools.install", dst:"/tmp/debs969490515/debian/cri-tools.install", t:(*template.Template)(0xc000070ec0), info:(*os.fileStat)(0xc0002aaf70)}
2019/09/26 09:36:54 w: main.work{src:"packages/latest/cri-tools/debian/rules", dst:"/tmp/debs969490515/debian/rules", t:(*template.Template)(0xc000070f80), info:(*os.fileStat)(0xc0002ab2b0)}
dpkg-buildpackage: info: source package cri-tools
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs969490515
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.16.0/crictl-v1.16.0-linux-amd64.tar.gz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package cri-tools: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'cri-tools' in '../cri-tools_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../cri-tools_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs969490515
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/26 09:37:05 download link base is 
2019/09/26 09:37:05 download link base is https://dl.k8s.io/ci/v1.17.0-alpha.0.1832+d8a420c0d810da
2019/09/26 09:37:05 package name is cri-tools
2019/09/26 09:37:05 CRI tools function
2019/09/26 09:37:05 using CRI version
2019/09/26 09:37:05 [1 17 0-alpha 0 1832-d8a420c0d810da], len: 5
2019/09/26 09:37:05 CRI minor is 17
2019/09/26 09:37:05 CRI minor is 16
2019/09/26 09:37:05 package version is 1.16.0
2019/09/26 09:37:05 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0000f4510), Arch:"amd64", DebArch:"amd64", Package:"cri-tools", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/26 09:37:05 /tmp/debs115227030/debian
2019/09/26 09:37:05 w: main.work{src:"packages/latest/cri-tools/debian/changelog", dst:"/tmp/debs115227030/debian/changelog", t:(*template.Template)(0xc00058a380), info:(*os.fileStat)(0xc0004001a0)}
2019/09/26 09:37:05 w: main.work{src:"packages/latest/cri-tools/debian/compat", dst:"/tmp/debs115227030/debian/compat", t:(*template.Template)(0xc00058a4c0), info:(*os.fileStat)(0xc0004004e0)}
2019/09/26 09:37:05 w: main.work{src:"packages/latest/cri-tools/debian/control", dst:"/tmp/debs115227030/debian/control", t:(*template.Template)(0xc00058a5c0), info:(*os.fileStat)(0xc000400820)}
2019/09/26 09:37:05 w: main.work{src:"packages/latest/cri-tools/debian/copyright", dst:"/tmp/debs115227030/debian/copyright", t:(*template.Template)(0xc00058a6c0), info:(*os.fileStat)(0xc000400b60)}
2019/09/26 09:37:05 w: main.work{src:"packages/latest/cri-tools/debian/cri-tools.install", dst:"/tmp/debs115227030/debian/cri-tools.install", t:(*template.Template)(0xc00058a780), info:(*os.fileStat)(0xc000400ea0)}
2019/09/26 09:37:05 w: main.work{src:"packages/latest/cri-tools/debian/rules", dst:"/tmp/debs115227030/debian/rules", t:(*template.Template)(0xc00058a840), info:(*os.fileStat)(0xc0004011e0)}
dpkg-buildpackage: info: source package cri-tools
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs115227030
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.16.0/crictl-v1.16.0-linux-amd64.tar.gz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package cri-tools: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'cri-tools' in '../cri-tools_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../cri-tools_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs115227030
dpkg-buildpackage: info: binary-only upload (no source included)

real	3m56.566s
user	6m38.344s
sys	0m18.891s

And the resulting debs:

$ ls -alh bin/*
bin/stable:
total 54M
drwxr-xr-x 2 augustus augustus 4.0K Sep 26 09:36 .
drwxr-xr-x 5 augustus augustus 4.0K Sep 26 09:34 ..
-rw-r--r-- 1 augustus augustus  11M Sep 26 09:36 cri-tools_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 8.4M Sep 26 09:36 kubeadm_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 8.9M Sep 26 09:33 kubectl_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus  20M Sep 26 09:34 kubelet_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 7.0M Sep 26 09:35 kubernetes-cni_0.7.5-0_amd64.deb

bin/testing:
total 70M
drwxr-xr-x 2 augustus augustus 4.0K Sep 26 09:37 .
drwxr-xr-x 5 augustus augustus 4.0K Sep 26 09:34 ..
-rw-r--r-- 1 augustus augustus  11M Sep 26 09:37 cri-tools_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 8.1M Sep 26 09:36 kubeadm_1.17.0-alpha.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 8.8M Sep 26 09:33 kubectl_1.17.0-alpha.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus  20M Sep 26 09:34 kubelet_1.17.0-alpha.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus  24M Sep 26 09:35 kubernetes-cni_0.8.2-0_amd64.deb

bin/unstable:
total 109M
drwxr-xr-x 2 augustus augustus 4.0K Sep 26 09:37 .
drwxr-xr-x 5 augustus augustus 4.0K Sep 26 09:34 ..
-rw-r--r-- 1 augustus augustus  11M Sep 26 09:37 cri-tools_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus  18M Sep 26 09:36 kubeadm_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.deb
-rw-r--r-- 1 augustus augustus  19M Sep 26 09:34 kubectl_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.deb
-rw-r--r-- 1 augustus augustus  39M Sep 26 09:35 kubelet_1.17.0-alpha.0.1832-d8a420c0d810da-0_amd64.deb
-rw-r--r-- 1 augustus augustus  24M Sep 26 09:35 kubernetes-cni_0.8.2-0_amd64.deb
@bai

This comment has been minimized.

Copy link

bai commented Sep 27, 2019

Sorry for jumping in uninvited, I think you might also need to replace

COPY --chown=builder:builder bionic ./bionic
COPY --chown=builder:builder jessie ./jessie
COPY --chown=builder:builder sid ./sid
COPY --chown=builder:builder stretch ./stretch
COPY --chown=builder:builder trusty ./trusty
COPY --chown=builder:builder xenial ./xenial

with

COPY --chown=builder:builder packages ./packages

in build/debs/Dockerfile.

@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Sep 27, 2019

@bai -- No need to apologize. You caught something I missed! Thanks :)
Fixed in 1a9fbdd.

@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Sep 27, 2019

I tweaked this some more to add a few more CLI flags so we can build arbitrary sets of packages.

Here's an example:
$ time go run build.go -arch amd64 -cni-version 0.8.2 -packages cri-tools,kubeadm,kubernetes-cni -distributions stable,testing:

2019/09/27 10:11:37 download link base is 
2019/09/27 10:11:37 download link base is https://dl.k8s.io/v1.16.0
2019/09/27 10:11:37 package name is cri-tools
2019/09/27 10:11:37 CRI tools function
2019/09/27 10:11:37 using CRI version
2019/09/27 10:11:37 [1 16 0], len: 3
2019/09/27 10:11:37 package version is 1.16.0
2019/09/27 10:11:37 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0000b0240), Arch:"amd64", DebArch:"amd64", Package:"cri-tools", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/27 10:11:37 /tmp/debs745298073/debian
2019/09/27 10:11:37 w: main.work{src:"packages/latest/cri-tools/debian/changelog", dst:"/tmp/debs745298073/debian/changelog", t:(*template.Template)(0xc0002c4480), info:(*os.fileStat)(0xc0002b2340)}
2019/09/27 10:11:37 w: main.work{src:"packages/latest/cri-tools/debian/compat", dst:"/tmp/debs745298073/debian/compat", t:(*template.Template)(0xc0002c45c0), info:(*os.fileStat)(0xc0002b2680)}
2019/09/27 10:11:37 w: main.work{src:"packages/latest/cri-tools/debian/control", dst:"/tmp/debs745298073/debian/control", t:(*template.Template)(0xc0002c4700), info:(*os.fileStat)(0xc0002b29c0)}
2019/09/27 10:11:37 w: main.work{src:"packages/latest/cri-tools/debian/copyright", dst:"/tmp/debs745298073/debian/copyright", t:(*template.Template)(0xc0002c4800), info:(*os.fileStat)(0xc0002b2d00)}
2019/09/27 10:11:37 w: main.work{src:"packages/latest/cri-tools/debian/cri-tools.install", dst:"/tmp/debs745298073/debian/cri-tools.install", t:(*template.Template)(0xc0002c48c0), info:(*os.fileStat)(0xc0002b3040)}
2019/09/27 10:11:37 w: main.work{src:"packages/latest/cri-tools/debian/rules", dst:"/tmp/debs745298073/debian/rules", t:(*template.Template)(0xc0002c4980), info:(*os.fileStat)(0xc0002b3380)}
dpkg-buildpackage: info: source package cri-tools
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs745298073
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.16.0/crictl-v1.16.0-linux-amd64.tar.gz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package cri-tools: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'cri-tools' in '../cri-tools_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../cri-tools_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs745298073
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/27 10:11:49 download link base is 
2019/09/27 10:11:49 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/27 10:11:49 package name is cri-tools
2019/09/27 10:11:49 CRI tools function
2019/09/27 10:11:49 using CRI version
2019/09/27 10:11:49 [1 17 0-alpha 0], len: 4
2019/09/27 10:11:49 CRI minor is 17
2019/09/27 10:11:49 CRI minor is 16
2019/09/27 10:11:49 package version is 1.16.0
2019/09/27 10:11:49 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000012510), Arch:"amd64", DebArch:"amd64", Package:"cri-tools", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/27 10:11:49 /tmp/debs553687844/debian
2019/09/27 10:11:49 w: main.work{src:"packages/latest/cri-tools/debian/changelog", dst:"/tmp/debs553687844/debian/changelog", t:(*template.Template)(0xc0002c4e00), info:(*os.fileStat)(0xc00017ea90)}
2019/09/27 10:11:49 w: main.work{src:"packages/latest/cri-tools/debian/compat", dst:"/tmp/debs553687844/debian/compat", t:(*template.Template)(0xc0002c4f40), info:(*os.fileStat)(0xc00017edd0)}
2019/09/27 10:11:49 w: main.work{src:"packages/latest/cri-tools/debian/control", dst:"/tmp/debs553687844/debian/control", t:(*template.Template)(0xc0002c5000), info:(*os.fileStat)(0xc00017f110)}
2019/09/27 10:11:49 w: main.work{src:"packages/latest/cri-tools/debian/copyright", dst:"/tmp/debs553687844/debian/copyright", t:(*template.Template)(0xc0002c5100), info:(*os.fileStat)(0xc00017f450)}
2019/09/27 10:11:49 w: main.work{src:"packages/latest/cri-tools/debian/cri-tools.install", dst:"/tmp/debs553687844/debian/cri-tools.install", t:(*template.Template)(0xc0002c51c0), info:(*os.fileStat)(0xc00017f790)}
2019/09/27 10:11:49 w: main.work{src:"packages/latest/cri-tools/debian/rules", dst:"/tmp/debs553687844/debian/rules", t:(*template.Template)(0xc0002c5280), info:(*os.fileStat)(0xc00017fad0)}
dpkg-buildpackage: info: source package cri-tools
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs553687844
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.16.0/crictl-v1.16.0-linux-amd64.tar.gz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package cri-tools: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'cri-tools' in '../cri-tools_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../cri-tools_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs553687844
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/27 10:12:01 download link base is 
2019/09/27 10:12:01 download link base is https://dl.k8s.io/v1.16.0
2019/09/27 10:12:01 package name is kubeadm
2019/09/27 10:12:01 using Kubernetes version
2019/09/27 10:12:01 package version is 1.16.0
2019/09/27 10:12:01 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc000012900), Arch:"amd64", DebArch:"amd64", Package:"kubeadm", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/27 10:12:01 /tmp/debs679194675/debian
2019/09/27 10:12:01 /tmp/debs679194675/debian/source
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/10-kubeadm.conf", dst:"/tmp/debs679194675/10-kubeadm.conf", t:(*template.Template)(0xc0002c5680), info:(*os.fileStat)(0xc000467110)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/changelog", dst:"/tmp/debs679194675/debian/changelog", t:(*template.Template)(0xc0002c5780), info:(*os.fileStat)(0xc000467520)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/compat", dst:"/tmp/debs679194675/debian/compat", t:(*template.Template)(0xc0002c5880), info:(*os.fileStat)(0xc000467860)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/control", dst:"/tmp/debs679194675/debian/control", t:(*template.Template)(0xc0002c5940), info:(*os.fileStat)(0xc000467ba0)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/copyright", dst:"/tmp/debs679194675/debian/copyright", t:(*template.Template)(0xc0002c5a40), info:(*os.fileStat)(0xc000467ee0)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/kubeadm.install", dst:"/tmp/debs679194675/debian/kubeadm.install", t:(*template.Template)(0xc0002c5b00), info:(*os.fileStat)(0xc000508270)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/postinst", dst:"/tmp/debs679194675/debian/postinst", t:(*template.Template)(0xc0002c5c00), info:(*os.fileStat)(0xc0005085b0)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/rules", dst:"/tmp/debs679194675/debian/rules", t:(*template.Template)(0xc0002c5cc0), info:(*os.fileStat)(0xc0005088f0)}
2019/09/27 10:12:01 w: main.work{src:"packages/latest/kubeadm/debian/source/format", dst:"/tmp/debs679194675/debian/source/format", t:(*template.Template)(0xc0002c5dc0), info:(*os.fileStat)(0xc000508d00)}
dpkg-buildpackage: info: source package kubeadm
dpkg-buildpackage: info: source version 1.16.0-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs679194675
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl --fail -sSL --retry 5 \
	-o usr/bin/kubeadm \
	"https://dl.k8s.io/v1.16.0/bin/linux/amd64/kubeadm"
chmod +x usr/bin/kubeadm
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubeadm' in '../kubeadm_1.16.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubeadm_1.16.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs679194675
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/27 10:12:16 download link base is 
2019/09/27 10:12:16 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/27 10:12:16 package name is kubeadm
2019/09/27 10:12:16 using Kubernetes version
2019/09/27 10:12:16 package version is 1.17.0-alpha.0
2019/09/27 10:12:16 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc0000b0090), Arch:"amd64", DebArch:"amd64", Package:"kubeadm", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/27 10:12:16 /tmp/debs353753590/debian
2019/09/27 10:12:16 /tmp/debs353753590/debian/source
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/10-kubeadm.conf", dst:"/tmp/debs353753590/10-kubeadm.conf", t:(*template.Template)(0xc0000ae600), info:(*os.fileStat)(0xc0000a0750)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/changelog", dst:"/tmp/debs353753590/debian/changelog", t:(*template.Template)(0xc0000ae740), info:(*os.fileStat)(0xc0000a1110)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/compat", dst:"/tmp/debs353753590/debian/compat", t:(*template.Template)(0xc0000ae840), info:(*os.fileStat)(0xc0000a1450)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/control", dst:"/tmp/debs353753590/debian/control", t:(*template.Template)(0xc0000ae900), info:(*os.fileStat)(0xc0000a1790)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/copyright", dst:"/tmp/debs353753590/debian/copyright", t:(*template.Template)(0xc0000aea00), info:(*os.fileStat)(0xc0000a1ad0)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/kubeadm.install", dst:"/tmp/debs353753590/debian/kubeadm.install", t:(*template.Template)(0xc0000aeac0), info:(*os.fileStat)(0xc0000a1e10)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/postinst", dst:"/tmp/debs353753590/debian/postinst", t:(*template.Template)(0xc0000aebc0), info:(*os.fileStat)(0xc0002b2270)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/rules", dst:"/tmp/debs353753590/debian/rules", t:(*template.Template)(0xc0000aec80), info:(*os.fileStat)(0xc0002b25b0)}
2019/09/27 10:12:16 w: main.work{src:"packages/latest/kubeadm/debian/source/format", dst:"/tmp/debs353753590/debian/source/format", t:(*template.Template)(0xc0000aed80), info:(*os.fileStat)(0xc0002b29c0)}
dpkg-buildpackage: info: source package kubeadm
dpkg-buildpackage: info: source version 1.17.0-alpha.0-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs353753590
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p usr/bin
curl --fail -sSL --retry 5 \
	-o usr/bin/kubeadm \
	"https://dl.k8s.io/v1.17.0-alpha.0/bin/linux/amd64/kubeadm"
chmod +x usr/bin/kubeadm
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubeadm' in '../kubeadm_1.17.0-alpha.0-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubeadm_1.17.0-alpha.0-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs353753590
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/27 10:12:30 download link base is 
2019/09/27 10:12:30 download link base is https://dl.k8s.io/v1.16.0
2019/09/27 10:12:30 package name is kubernetes-cni
2019/09/27 10:12:30 using CNI version
2019/09/27 10:12:30 checking kube version (1.16.0) against 1.17.0-alpha.0
2019/09/27 10:12:30 package version is 0.7.5
2019/09/27 10:12:30 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc00037a2d0), Arch:"amd64", DebArch:"amd64", Package:"kubernetes-cni", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/27 10:12:30 /tmp/debs490486493/debian
2019/09/27 10:12:30 w: main.work{src:"packages/latest/kubernetes-cni/.gitignore", dst:"/tmp/debs490486493/.gitignore", t:(*template.Template)(0xc0000af240), info:(*os.fileStat)(0xc0002b3ee0)}
2019/09/27 10:12:30 w: main.work{src:"packages/latest/kubernetes-cni/debian/changelog", dst:"/tmp/debs490486493/debian/changelog", t:(*template.Template)(0xc0000af340), info:(*os.fileStat)(0xc00019a340)}
2019/09/27 10:12:30 w: main.work{src:"packages/latest/kubernetes-cni/debian/compat", dst:"/tmp/debs490486493/debian/compat", t:(*template.Template)(0xc0000af440), info:(*os.fileStat)(0xc00019a680)}
2019/09/27 10:12:30 w: main.work{src:"packages/latest/kubernetes-cni/debian/control", dst:"/tmp/debs490486493/debian/control", t:(*template.Template)(0xc0000af500), info:(*os.fileStat)(0xc00019a9c0)}
2019/09/27 10:12:30 w: main.work{src:"packages/latest/kubernetes-cni/debian/copyright", dst:"/tmp/debs490486493/debian/copyright", t:(*template.Template)(0xc0000af600), info:(*os.fileStat)(0xc00019af70)}
2019/09/27 10:12:30 w: main.work{src:"packages/latest/kubernetes-cni/debian/kubernetes-cni.install", dst:"/tmp/debs490486493/debian/kubernetes-cni.install", t:(*template.Template)(0xc0000af6c0), info:(*os.fileStat)(0xc00019b2b0)}
2019/09/27 10:12:30 w: main.work{src:"packages/latest/kubernetes-cni/debian/rules", dst:"/tmp/debs490486493/debian/rules", t:(*template.Template)(0xc0000af780), info:(*os.fileStat)(0xc00019b5f0)}
dpkg-buildpackage: info: source package kubernetes-cni
dpkg-buildpackage: info: source version 0.7.5-0
dpkg-buildpackage: info: source distribution stable
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs490486493
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/containernetworking/plugins/releases/download/v0.7.5/cni-plugins-amd64-v0.7.5.tgz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package kubernetes-cni: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubernetes-cni' in '../kubernetes-cni_0.7.5-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubernetes-cni_0.7.5-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs490486493
dpkg-buildpackage: info: binary-only upload (no source included)
2019/09/27 10:12:42 download link base is 
2019/09/27 10:12:42 download link base is https://dl.k8s.io/v1.17.0-alpha.0
2019/09/27 10:12:42 package name is kubernetes-cni
2019/09/27 10:12:42 using CNI version
2019/09/27 10:12:42 checking kube version (1.17.0-alpha.0) against 1.17.0-alpha.0
2019/09/27 10:12:42 package version is 0.8.2
2019/09/27 10:12:42 !!!!!!!!! doing: main.cfg{packageDefinition:(*main.packageDefinition)(0xc00037a630), Arch:"amd64", DebArch:"amd64", Package:"kubernetes-cni", Dependencies:"kubelet (>= 1.13.0), kubectl (>= 1.13.0), kubernetes-cni (>= 0.7.5), cri-tools (>= 1.13.0), ${misc:Depends}"}
2019/09/27 10:12:42 /tmp/debs379369624/debian
2019/09/27 10:12:42 w: main.work{src:"packages/latest/kubernetes-cni/.gitignore", dst:"/tmp/debs379369624/.gitignore", t:(*template.Template)(0xc0002c4500), info:(*os.fileStat)(0xc0004400d0)}
2019/09/27 10:12:42 w: main.work{src:"packages/latest/kubernetes-cni/debian/changelog", dst:"/tmp/debs379369624/debian/changelog", t:(*template.Template)(0xc0002c4680), info:(*os.fileStat)(0xc0004404e0)}
2019/09/27 10:12:42 w: main.work{src:"packages/latest/kubernetes-cni/debian/compat", dst:"/tmp/debs379369624/debian/compat", t:(*template.Template)(0xc0002c4780), info:(*os.fileStat)(0xc000440820)}
2019/09/27 10:12:42 w: main.work{src:"packages/latest/kubernetes-cni/debian/control", dst:"/tmp/debs379369624/debian/control", t:(*template.Template)(0xc0002c4840), info:(*os.fileStat)(0xc000440b60)}
2019/09/27 10:12:42 w: main.work{src:"packages/latest/kubernetes-cni/debian/copyright", dst:"/tmp/debs379369624/debian/copyright", t:(*template.Template)(0xc0002c4940), info:(*os.fileStat)(0xc000440ea0)}
2019/09/27 10:12:42 w: main.work{src:"packages/latest/kubernetes-cni/debian/kubernetes-cni.install", dst:"/tmp/debs379369624/debian/kubernetes-cni.install", t:(*template.Template)(0xc0002c4a00), info:(*os.fileStat)(0xc0004411e0)}
2019/09/27 10:12:42 w: main.work{src:"packages/latest/kubernetes-cni/debian/rules", dst:"/tmp/debs379369624/debian/rules", t:(*template.Template)(0xc0002c4ac0), info:(*os.fileStat)(0xc000441520)}
dpkg-buildpackage: info: source package kubernetes-cni
dpkg-buildpackage: info: source version 0.8.2-0
dpkg-buildpackage: info: source distribution testing
dpkg-buildpackage: info: source changed by Kubernetes Authors <kubernetes-dev@googlegroups.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build debs379369624
 fakeroot debian/rules clean
dh clean
   dh_clean
 debian/rules build
echo noop
noop
 fakeroot debian/rules binary
mkdir -p ./bin
curl -sSL --fail --retry 5 \
	"https://github.com/containernetworking/plugins/releases/download/v0.8.2/cni-plugins-linux-amd64-v0.8.2.tgz" \
	| tar -C ./bin -xz
dh_testroot
dh_auto_install
dh_shlibdeps
dh_install
dh_installdeb
dh_gencontrol
dpkg-gencontrol: warning: Depends field of package kubernetes-cni: unknown substitution variable ${shlibs:Depends}
dh_md5sums
dh_builddeb
dpkg-deb: building package 'kubernetes-cni' in '../kubernetes-cni_0.8.2-0_amd64.deb'.
 dpkg-genbuildinfo --build=binary
 dpkg-genchanges --build=binary >../kubernetes-cni_0.8.2-0_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --after-build debs379369624
dpkg-buildpackage: info: binary-only upload (no source included)

real	1m18.466s
user	1m43.774s
sys	0m6.130s

and the resulting packages:

$ ls -alh bin/*
bin/stable:
total 26M
drwxr-xr-x 2 augustus augustus 4.0K Sep 27 10:12 .
drwxr-xr-x 4 augustus augustus 4.0K Sep 27 10:12 ..
-rw-r--r-- 1 augustus augustus  11M Sep 27 10:11 cri-tools_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 8.4M Sep 27 10:12 kubeadm_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 7.0M Sep 27 10:12 kubernetes-cni_0.7.5-0_amd64.deb

bin/testing:
total 42M
drwxr-xr-x 2 augustus augustus 4.0K Sep 27 10:12 .
drwxr-xr-x 4 augustus augustus 4.0K Sep 27 10:12 ..
-rw-r--r-- 1 augustus augustus  11M Sep 27 10:12 cri-tools_1.16.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus 8.1M Sep 27 10:12 kubeadm_1.17.0-alpha.0-0_amd64.deb
-rw-r--r-- 1 augustus augustus  24M Sep 27 10:12 kubernetes-cni_0.8.2-0_amd64.deb
@bai

This comment has been minimized.

Copy link

bai commented Sep 27, 2019

Is it intended that cri-tools are bound to kubernetes version? E.g. https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.16.1 was released 2 days ago, but with this PR it'll always try to match cri-tools version with kubernetes version: https://github.com/kubernetes/release/pull/884/files#diff-425ad2a19e5c7f50fe5a5163f21cfa04R54

One more thing

Kinda unrelated but please correct me if I'm wrong, it seems like both in current master and on this branch there's a bug in package.sh.

This line: https://github.com/kubernetes/release/blob/master/build/package.sh#L74 should actually read:

"${docker_run_cmd[@]}" --rm -v "${OUTPUT_DIR}:/home/builder/workspace/bin" "${IMG_NAME}" "$@"

since packages are built in /home/builder/workspace/bin and not in /src/bin:

# example command to make a local build
$ PACKAGE_TYPE=debs ./build/package.sh --kube-version 1.16.0 --arch amd64
@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Sep 27, 2019

@bai --

Is it intended that cri-tools are bound to kubernetes version? E.g. https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.16.1 was released 2 days ago, but with this PR it'll always try to match cri-tools version with kubernetes version: https://github.com/kubernetes/release/pull/884/files#diff-425ad2a19e5c7f50fe5a5163f21cfa04R54

Nice catch! I purposely bound the cri-tools version to the Kubernetes minor version, as k-sig/cri-tools was primarily only publishing one release per Kubernetes minor version: https://github.com/kubernetes-sigs/cri-tools/tags

I'll add some logic to this to figure out the latest patch release of cri-tools.

Kinda unrelated but please correct me if I'm wrong, it seems like both in current master and on this branch there's a bug in package.sh.

Yep, package.sh is actually broken at the moment.
I'll come back and fix it in a follow-up PR, once we finish refactoring the deb and rpm build tools. :)

kubeVersionString := kubeSemver.String()
kubeVersionParts := strings.Split(kubeVersionString, ".")

log.Printf("%v, len: %s", kubeVersionParts, len(kubeVersionParts))

This comment has been minimized.

Copy link
@bai

bai Sep 27, 2019

Suggested change
log.Printf("%v, len: %s", kubeVersionParts, len(kubeVersionParts))
log.Printf("%v, len: %d", kubeVersionParts, len(kubeVersionParts))
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Sep 27, 2019

@bai -- Fixed the CRI tools version selection and that log line you mention above in a0f945d.

ChannelNightly ChannelType = "nightly"
DistributionStable DistributionType = "stable"
DistributionUnstable DistributionType = "unstable"
DistributionTesting DistributionType = "testing"

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

What's the rationale for this rename? The current names feel slightly unclear in meaning and I don't follow how the new names improve this.

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

Aaah in a later patch you reorder to unstable, testing, stable. So unstable is some type of periodic (nightly?), testing is something that's promoted out of the periodic for broader test consumption, and stable is something that's promoted out of test?

This comment has been minimized.

Copy link
@justaugustus

justaugustus Sep 28, 2019

Author Member

@tpepper -- yep, nailed it! I based the naming on the Debian package streams:

  • stable: "This is stable and well tested software, which changes only if major security or usability fixes are incorporated."
  • testing: "This area contains packages that are intended to become part of the next stable distribution. There are strict criteria a package in unstable (see below) must obey before it can be added to testing. Note that testing does not get the timely security updates from the security team."
  • unstable: "This area contains the most recent packages in Debian. Once a package has met our criterion for stability and quality of packaging, it will be included in testing. unstable is also not supported by the security team. Packages in unstable are the least tested and may contain problems severe enough to affect the stability of your system. Only experienced users should consider using this distribution."

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

You may notice I'm not the huge-est fan of the Debian influenced naming. I just don't feel "unstable" is accurate, when it's more typically a periodic build. If we're doing things right, the periodics are stable, do then promote to testing, and do then to promote to stable.

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

While these packages are for Debian, our channels should be named consistently for our project and its users. For those who are Debian users the Debian names might be familiar, but they may not follow the principle of least surprise for other OS users or be appropriate for our intended build/publish/promote workflow.


packagesRootDir = "packages"

kubeadmConf = "10-kubeadm.conf"
)

var latestPackagesDir = fmt.Sprintf("%s/%s", packagesRootDir, "latest")
var (
minimumCRIToolsVersion = minimumKubernetesVersion

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

I'm not sure this a safe default. It's probably the general intent, but we regularly end up with mismatches because things weren't tested in conjunction with one another and then move forward out of sync, eg: kubernetes/kubernetes#83217

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

I think the default should be to build a specified combination. These dependencies should be specified elsewhere consistently and everything consume that source of truth, instead of making other default assumptions.

Revision string

KubernetesVersion string
KubeletCNIVersion string

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

What's the rationale for not having CRI here?

return getTestingKubeVersion()
case DistributionUnstable:
return getUnstableKubeVersion()
}

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

Style nit: this should have the getStableKubeVersion() happen for an explicit case, plus a default case that returns an error explicitly for unknown cases. We may over time add and remove distribution types, modifying such switch statements, so having them explicit and throw errors for unhandled cases likely reduces future bugs.

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

Going further through review I'm seeing a lot of differences across the per-channel switch statements. I suggest consistently doing explicitly:

  • case channel foo
  • case channel bar
  • case channel baz
  • default: error

for ease of maintenance.

fmt.Sprintf("kubernetes-cni (%s)", cniVersion),
fmt.Sprintf("kubelet (>= %s)", minimumKubernetesVersion),
fmt.Sprintf("kubectl (>= %s)", minimumKubernetesVersion),
fmt.Sprintf("kubernetes-cni (>= %s)", minimumCNIVersion),

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

My regular reminder..unilaterally moving these to ">=" is a policy change and is known to break things for end users given how we test and publish today. This code wont be able to actually be used on production build machines until we have modified our publication streams on the server side.

if err != nil {
return "", err
}

v1110, err := semver.Make("1.11.0-alpha.0")
v117, err := semver.Make("1.17.0-alpha.0")

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

Why is this configuration hard coded as a string constant and further encoded in variable naming?

return "", err
}
v1121, err := semver.Make("1.12.1-alpha.0")
v075, err := semver.Make(pre117CNIVersion)

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

This should be config.


var err error

// TODO: Allow building packages for a specific distro type

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

By "distro type" here do you mean OS distribution, a variation for which you've mostly removed support, or the unstable/testing/stable distribution channel? "distro" is overloaded, so it might be beneficial to use something more evocative of the release distribution channel concept.

Personally I'm ok with us not building distinctly for a dozen different Debian/Ubuntu targets, specifying the one we do build on and that runtime mileage may vary if the host is different than that. We can't build and test them all.

ChannelNightly ChannelType = "nightly"
DistributionStable DistributionType = "stable"
DistributionUnstable DistributionType = "unstable"
DistributionTesting DistributionType = "testing"

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

You may notice I'm not the huge-est fan of the Debian influenced naming. I just don't feel "unstable" is accurate, when it's more typically a periodic build. If we're doing things right, the periodics are stable, do then promote to testing, and do then to promote to stable.


log.Printf("download link base is %s", c.DownloadLinkBase)

// TODO: Add note about this

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

what is it?

@@ -118,7 +121,8 @@ var (
)

func init() {
// TODO: Add flag support to build stable, testing, or unstable versions
flag.Var(&packages, "packages", "packages to build")
flag.Var(&distributions, "distributions", "distributions to build for")

This comment has been minimized.

Copy link
@tpepper

tpepper Sep 28, 2019

Contributor

This is the "channel"?

Copy link
Contributor

tpepper left a comment

I'm not seeing clear value in the chosen default CRI::Kubernetes version mapping. I think build should happen based on external configuration (default) or explicit runtime override. This is an important split to start us moving toward more explicit curation of the variations. Allowing effectively arbitrary variations to be built implicitly by different tools in the pipeline means more places somebody needs to know to update in order to maintain things as new versions come out.

you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0

This comment has been minimized.

Copy link
@neolit123

neolit123 Sep 30, 2019

Member

does this line have extra indentation?

pre1110kubeadmconf = "post-1.8/10-kubeadm.conf"
latestkubeadmconf = "post-1.10/10-kubeadm.conf"
cniVersion = "0.7.5"
criToolsVersion = "1.13.0"

This comment has been minimized.

Copy link
@neolit123

neolit123 Sep 30, 2019

Member

i think we might want to drop the magic build.go is doing in terms of version handling for cni/cri, long term.
it's fighting the deficiency of not having separate spec files or release branches.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Sep 30, 2019

LGTM on the overall refactor.
thanks @justaugustus

justaugustus added 11 commits Sep 24, 2019
There is a fair amount of symlinking and reference to Debian/Ubuntu
versions, which is not required (and probably hasn't been for a while).
When building and publishing debs, we publish them to a single apt repo
(https://packages.cloud.google.com/apt/dists/kubernetes-xenial) which
makes no distinction between the packages within.

This commit moves the deb package definitions to `packages/latest` and
removes all symlinks. The deb build program is also slightly refactored
here to reference the true distribution types (stable, testing, unstable).

Future commits will divide the package definitions so we can modify the
structure and dependencies of packages for specific versions of
Kubernetes without affecting previous versions.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
We've created an artificial directory structure for arbitrary files
that get copied into the kubeadm package. This is unnecessary as
kubeadm.install handles the file locations correctly.

This commit also removes the symlinks to separate channels, which were unused.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
dpkg-buildpackage throws the following warning for cri-tools when run:
"dpkg-buildpackage: warning: debian/rules is not executable; fixing that"

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
- Set explicit dependency versions of CRI tools and CNI plugins
- Allow building cri-tools and kubernetes-cni packages which
   correspond to Kubernetes versions
- Set default package revision to "0"
- Rename "version" struct to "packageDefinition", which is more indicative
   of the values it contains
- Add cni-version flag to allow building arbitrary versions of kubernetes-cni
- Remove logic for symlinking package definition directories
- Add CNIDownloadLink to handle changes in CNI plugin download links
   between 0.7.x and 0.8.x

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
No code changes; just moving functions around to improve readability.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Here we collapse the builds structs in main() into a function
(constructBuilds) as well as provide additional cli flags for package
and disribution. This allows us to build arbitrary combinations of
packages instead of the entire package set for all distributions.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Additionally, when the CRI tools version is not specified, we will try
to build the latest patch version of CRI tools that corresponds with the
Kubernetes version.

Examples (current as of this original commit time):
- Kubernetes version (1.16.0) --> CRI tools version (1.16.1)
- Kubernetes version (1.15.4) --> CRI tools version (1.15.0)

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
After discussing with tpepper, we're going to use "channel" instead of
"distribution" to describe a package stream.

The following channel names will be used:
- "release": stable versions of Kubernetes (x.y.z)
- "testing": pre-release versions of Kubernetes (x.y.z-{alpha,beta,rc}.m)
- "nightly": build versions of Kubernetes
(x.y.z-{alpha,beta,rc}.m.nnnn+SHA)

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus force-pushed the justaugustus:deb-refactor branch from f31f83f to bea0fad Oct 9, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 9, 2019

@justaugustus: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-release-test bea0fad link /test pull-release-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus justaugustus changed the title debs: Support per Kubernetes release package definitions debs: Support building arbitrary combinations of release packages Oct 9, 2019
@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Oct 9, 2019

Chatted with @tpepper and I'm going to merge this one and continue the work in a follow-up before we get into rebase trouble.

@justaugustus justaugustus merged commit 015c48d into kubernetes:master Oct 9, 2019
2 of 4 checks passed
2 of 4 checks passed
pull-release-test Job failed.
Details
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation justaugustus authorized
Details
pull-release-cluster-up Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 9, 2019
@bai

This comment has been minimized.

Copy link

bai commented Oct 9, 2019

Happy to see this one merged, thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.