Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode on symlinks #124

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@cblecker
Copy link
Member

commented Aug 6, 2019

This fixes a bug in our build_tar implementation, where we were not forcing 0777 on symlinks. This is a specific issue on Darwin, because you can actually set the mode on symlinks (Linux just assumes 0777 for the symlink itself).

@ixdy

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Manually merging because Travis still sucks on this repo.

@cblecker cblecker merged commit 9f4571a into kubernetes:master Aug 6, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
tide Not mergeable. Job continuous-integration/travis-ci/pr has not succeeded.
Details
cla/linuxfoundation cblecker authorized
Details

@cblecker cblecker deleted the cblecker:fix-symlink-mode branch Aug 6, 2019

jsafrane added a commit to jsafrane/kubernetes that referenced this pull request Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.