Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: add release schedule in yaml machine readable format #1096

Merged
merged 1 commit into from Jul 17, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 21, 2020

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Adds the schedule of the patch release in the YAML format to make it easier to machines read and parse.

Will open a second PR again k/release to add a small command-line tool to convert from YAML to markdown format to help to publish the schedule here

TODO:

  • Add missing dates for the EOL for the existing releases.

Which issue(s) this PR fixes:

Special notes for your reviewer:

/cc @justaugustus @tpepper @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested review from justaugustus, tpepper and a team May 21, 2020 15:28
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 21, 2020
@cpanato
Copy link
Member Author

cpanato commented May 21, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels May 21, 2020
@tpepper
Copy link
Member

tpepper commented May 21, 2020

Did the parser not get a 'git add' before commit?

@cpanato
Copy link
Member Author

cpanato commented May 22, 2020

@tpepper the parser Stephen suggest adding in the k/release

@cpanato
Copy link
Member Author

cpanato commented May 26, 2020

@tpepper added the parser tool and update the schedule, just missing the EOL

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato -- I left a review on the tool: kubernetes/release#1313 (review)

@kubernetes/release-engineering -- Let's review and merge that PR before merging this.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@cpanato
Copy link
Member Author

cpanato commented May 28, 2020

@justaugustus thanks for the review, i will work to address the feedback!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2020
@cpanato
Copy link
Member Author

cpanato commented Jun 8, 2020

PR kubernetes/release#1313 was merged we can continue the review for this one here
cc @justaugustus for when you have some time thanks!

@tpepper
Copy link
Member

tpepper commented Jun 8, 2020

@cpanato can you add some unit tests also for the tool?

@cpanato
Copy link
Member Author

cpanato commented Jun 9, 2020

@tpepper yes, Tim, will add some tests

@cpanato
Copy link
Member Author

cpanato commented Jun 9, 2020

@tpepper added some here: kubernetes/release#1349

@cpanato
Copy link
Member Author

cpanato commented Jun 30, 2020

@tpepper @justaugustus PR to add the tool and PR for adding tests was merged.
we can proceed here

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2020
@cpanato
Copy link
Member Author

cpanato commented Jul 16, 2020

@tpepper I know we all are busy and this is not a too high priority, but it is hanging for some time. All the things that you requested are already merged, missing this PR here only.

thanks!

@tpepper
Copy link
Member

tpepper commented Jul 17, 2020

I'm ok merging this in its current state. I'd backed off on doing so since I wanted to see its lifecycle management documented, that got slotted behind Stephen's rewrite / unification of the branch and patch management role handbooks since it spans both roles and should just be in the one new doc, and that got stalled versus other things. I think multiple of us could do the doc update, but Stephen had a particular vision for how he wanted it done. Maybe if we can get that described we could help reduce his load if it's delegate-able.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2020
@justaugustus
Copy link
Member

I think the lifecycle of this can be documented outside of my deduplication and we can work it in to whichever final state we land on.

One ask: when documenting anything related to handling of this config, please do so in a separate markdown file instead of the existing handbook, so we don't have to worry about rebasing once I get time to sit down on this again.

Great work and sorry for the wait in merging!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a99d60c into kubernetes:master Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 17, 2020
@cpanato cpanato deleted the GH-718 branch July 18, 2020 13:52
@cpanato
Copy link
Member Author

cpanato commented Jul 18, 2020

thanks @tpepper @justaugustus lets try to sync what changes you all want and i can make that happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

machine readable release schedule
4 participants