Skip to content

Conversation

@annajung
Copy link
Contributor

@annajung annajung commented Oct 14, 2020

What type of PR is this:

/kind documentation
/kind cleanup

What this PR does / why we need it:

  • Add templates that can be used to communicate docs deadline to enhancement/docs PR owners (Please look at this commit to see which content were changed: bf3ac59)
  • Extract out the release timeline section into its own file to help with readability (removes use of h5 which is smaller than a regular text!)

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

/assign @savitharaghunathan @jimangel

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2020
@jimangel
Copy link
Member

There's a lot to be desired in the release timeline and I think we could clean up some of the meta "Read the release timeline" also within the release timeline, but overall this PR improves readability.

I would love to see the timeline cleaned up / stripped down to essentials for success.

Thanks @annajung for kicking off this clean-up!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 31bebf8 into kubernetes:master Oct 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants