Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split prow config from prow codebase #11782

Closed
5 of 6 tasks
stevekuznetsov opened this issue Mar 14, 2019 · 24 comments
Closed
5 of 6 tasks

Split prow config from prow codebase #11782

stevekuznetsov opened this issue Mar 14, 2019 · 24 comments
Assignees
Labels
area/config Issues or PRs related to code in /config area/jobs area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Mar 14, 2019

We're getting close to being ready for the move. Items we know we need to accomplish is here:

/cc @spiffxp @fejta @cjwagner @BenTheElder @krzyzacy

@stevekuznetsov stevekuznetsov added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 14, 2019
@stevekuznetsov
Copy link
Contributor Author

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2019
@StevenACoffman
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2019

Need to see what PR's modify config.yaml and plugin.yaml and decide if we want those to go through rebase fun

@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2019

/milestone v1.16
/assign

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 9, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2019

/assign @cjwagner

@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 25, 2019
@spiffxp spiffxp changed the title Move Prow to a repo under kubernetes-sigs Split prow config from prow codebase Jul 25, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 25, 2019

Rescoping based on what we thought was feasible for this quarter, moving to its own repo can be done as a followup

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2019
@stevekuznetsov
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2020
@BenTheElder
Copy link
Member

/remove-lifecycle stale

move prow/cluster to config/cluster
ensure all auto-bump etc automation around prow/cluster is updated

sounds relatively easy, maybe we should do that. @cjwagner @fejta thoughts?

submit KEP to create repo

you actually just have to file an issue in k/org after getting consensus from the SIG on wanting it, no KEP necessary. the process is pretty lightweight. moving code is a little more involved to do cleanly.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2020
@fejta
Copy link
Contributor

fejta commented Jan 21, 2020

Moving prow/cluster files into config/prow or somewhat like that sgtm

@spiffxp
Copy link
Member

spiffxp commented Apr 10, 2020

/area prow

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Apr 10, 2020
@spiffxp spiffxp removed this from the v1.16 milestone Apr 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2020
@BenTheElder
Copy link
Member

/remove-lifecycle stale

I think this is mostly done? pretty much everything is under config/.

submit KEP to create repo

we can actually do this with much less than a KEP, SIGs can sponsor a repo without going full KEP 🙃

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 4, 2020
@BenTheElder
Copy link
Member

I don't think there's any config lingering under prow/ now. some scripts / makefile stuff.

@alvaroaleman
Copy link
Member

Yeah, the config is pretty much moved out of the prow directory. What would be needed to move prow into its own repo is:

  • The repo itself
  • Exporting the code to the new repo
  • Setting up all prow-related jobs onto the new repo
  • Announcing this in case other projects reference prow code (kubetest2?)
  • Updating all references outside of /prow to prow

The point that is presumably most of the work is setting up the jobs on the new repo. It would be great to make this happen though, to better separate concerns and make certain tasks like updating dependencies easier 🙃

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 2, 2020
@StevenACoffman
Copy link

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 2, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 2, 2021

/remove-lifecycle stale
/lifecycle frozen
/priority important-longterm
/area config
/area jobs

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. area/config Issues or PRs related to code in /config area/jobs and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 2, 2021
@listx
Copy link
Contributor

listx commented Sep 3, 2022

Yeah, the config is pretty much moved out of the prow directory. What would be needed to move prow into its own repo is:

  • The repo itself

We have https://github.com/kubernetes-sigs/prow which could host the codebase. Currently it just holds Prow docs but most of the code there sits under a /site folder so it should be straightforward to move code in there (I expect us to basically do mv prow/* <new-repo> and commit that).

  • Setting up all prow-related jobs onto the new repo

I think at least for the jobs that publish new Prow images, they can be set up to use the code from the new repo and still publish into the same GCR locations, because the SHAs would be different so there wouldn't be any overlap. Once all of the presubmits and integration tests are set up to work on the new repo, I assume it would be OK to put a blockade on the old repo's /prow folder. Then the laborious task of setting up the Prow-related jobs can begin... and once that's done we can retire the old jobs.

I assume no one is currently working on this effort. But I am interested in this space.

@BenTheElder
Copy link
Member

This old issue got lost but https://github.com/kubernetes-sigs/prow exists now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

10 participants