Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: should the bot process comments from itself? #12138

Open
cblecker opened this Issue Apr 9, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@cblecker
Copy link
Member

cblecker commented Apr 9, 2019

Should the bot process comments that come from itself? Right now a couple plugins (sigmention, trigger, and soon project) have checks that if the comment comes from the bot, ignore it. Should this be something across the board?

There's a potential for functionality breaks:

  • Someone using something in a way we don't intend
  • Folks using the same token for a commenter, that they use for their main prow bot

But on the positive side:

  • Would prevent loops where the bot keeps reacting to comments it makes and tripping up DoS protections on GitHub or using up all it's tokens
  • Prevents potential privilege escalation where some exploits some flaw, and makes the bot comment with a privileged action that the user wouldn't otherwise have access to.

/area prow
/kind design
/cc @kubernetes/sig-testing

@cblecker

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.