Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exempt branches with a regex from branch protection #12954

Closed
cblecker opened this issue Jun 7, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@cblecker
Copy link
Member

commented Jun 7, 2019

What would you like to be added:
Allow for the exemption of certain branches from branch protection, based on matching a regex.

Why is this needed:
This would allow for easy deletion of branch accidentally created via GitHub's edit UI, as well as branches created by bots (such as GitHub's dependabot)

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

This would allow for easy deletion of branch accidentally created via GitHub's edit UI, as well as branches created by bots (such as GitHub's dependabot)

If enforce_admins: true is not used, I think this can be done today as well i.e. we won't need to disable branch protection to delete a branch.

For example, I see the option to delete all branches here - https://github.com/kubernetes/publishing-bot/settings/branches

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

@nikhita Those delete buttons are just to delete the branch protection rules themselves. The actual branch list is here: https://github.com/kubernetes/publishing-bot/branches. All the branches have the little lock symbol, and the trash can is greyed out.

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Those delete buttons are just to delete the branch protection rules themselves.

Ah, right! 🤦‍♀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.