Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use testgrid annotations instead of updating config.yaml #13057
What should be cleaned up or changed:
We should ensure this is documented. Then we should encourage more people to use these annotations instead of updating testgrid/config.yaml. One way we could do this is by setting the example and moving much of the existing config out of config.yaml. Perhaps piece by piece, maybe in an automated manner, etc.
Provide any links for context:
I'm going to do some research into this and am looking to deliver two things:
referenced this issue
Jun 27, 2019
This was referenced
Jul 12, 2019
With the addition of the manual migration PR and the Prow-Job-Detecting test, I think the issue is very close to resolved.
I'd like to get the Prow-Job-Detecting test in so that it can, eventually, be upgraded into a check that requires annotations where possible. Other than this one nice-to-have, the issue is as resolved as I can get it.
As mentioned in #13312, there are currently only 60 prow jobs that don't use annotations, and that's primarily due to special configurations.
Between these improvements and sharding the Testgrid Configurations (#13541), I don't anticipate this becoming an issue again in the near future. If it does, many of these tools can be reused to handle it.
@chases2: Closing this issue.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.