Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testgrid annotations instead of updating config.yaml #13057

Closed
spiffxp opened this issue Jun 17, 2019 · 6 comments

Comments

@spiffxp
Copy link
Member

commented Jun 17, 2019

What should be cleaned up or changed:
The testgrid configurator can now read prowjob annotations to create test groups (ref: #12576), which was used to simplify the creation of configs for release jobs and dashboards (#12608)

We should ensure this is documented. Then we should encourage more people to use these annotations instead of updating testgrid/config.yaml. One way we could do this is by setting the example and moving much of the existing config out of config.yaml. Perhaps piece by piece, maybe in an automated manner, etc.

Provide any links for context:

/sig testing
/help
/area jobs
/area testgrid

@chases2

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

I'm going to do some research into this and am looking to deliver two things:

  1. 1+ PRs that move configuration out of config.yaml when it's not needed
  2. A modification to Prow Job documentation that makes it clear what these annotations are, and why they are good

/assign

chases2 added a commit to chases2/test-infra that referenced this issue Jun 20, 2019

Refactoring of Testgrid Readme Files
Breaks apart single "mono-file" to files targeted to particular users:
- README.md is for users who want to use the website, or who don't know
what they want
- configuration.md is for users who want to change a configuration
- build_test_update.md is for users who want to develop TestGrid

See Issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jun 21, 2019

Refactoring of Testgrid Readme Files
Breaks apart single "mono-file" to files targeted to particular users:
- README.md is for users who want to use the website, or who don't know
what they want
- configuration.md is for users who want to change a configuration
- build_test_update.md is for users who want to develop TestGrid

See Issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jun 27, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jun 27, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057
@chases2

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

Item 2 has been delivered. Item 1 is in progress.
In addition, I'd like to 3) write a test that will detect future tabs that could be annotated.

We also need to take into account the recent expansion to what's annotatable.

/remove-help

chases2 added a commit to chases2/test-infra that referenced this issue Jun 27, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jul 1, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jul 1, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jul 2, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jul 2, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jul 3, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jul 3, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057

chases2 added a commit to chases2/test-infra that referenced this issue Jul 8, 2019

Addition of Migrator Script
Migrates Dashboard Tabs from config.yaml to a given prow directory
Meant to be run as part of a cleanup process for issue kubernetes#13057
@chases2

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

With the addition of the manual migration PR and the Prow-Job-Detecting test, I think the issue is very close to resolved.

I'd like to get the Prow-Job-Detecting test in so that it can, eventually, be upgraded into a check that requires annotations where possible. Other than this one nice-to-have, the issue is as resolved as I can get it.

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 22, 2019

@chases2

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

As mentioned in #13312, there are currently only 60 prow jobs that don't use annotations, and that's primarily due to special configurations.

Between these improvements and sharding the Testgrid Configurations (#13541), I don't anticipate this becoming an issue again in the near future. If it does, many of these tools can be reused to handle it.

/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@chases2: Closing this issue.

In response to this:

As mentioned in #13312, there are currently only 60 prow jobs that don't use annotations, and that's primarily due to special configurations.

Between these improvements and sharding the Testgrid Configurations (#13541), I don't anticipate this becoming an issue again in the near future. If it does, many of these tools can be reused to handle it.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.