Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shard testgrid config #13541

Closed
spiffxp opened this issue Jul 22, 2019 · 6 comments · Fixed by #14937
Closed

shard testgrid config #13541

spiffxp opened this issue Jul 22, 2019 · 6 comments · Fixed by #14937
Assignees
Labels
area/config Issues or PRs related to code in /config area/testgrid help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@spiffxp
Copy link
Member

spiffxp commented Jul 22, 2019

What should be cleaned up or changed:
Similar to how we have sharded up job configs by owning SIG to enable better self-service, let's shard up testgrid configs by owning SIG.

Provide any links for context:
Work has already started on this, linking relevant PR's:

/area testgrid
/area config
/milestone v1.16
/priority important-soon
/assign @chases2

@spiffxp spiffxp added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot added area/testgrid area/config Issues or PRs related to code in /config priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 22, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jul 22, 2019

/assign @michelle192837

@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 23, 2019
@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 25, 2019
@chases2
Copy link
Contributor

chases2 commented Jul 25, 2019

Our current system is now configured to take a directory tree at /config/testgrids, allowing us to split these files into any number of arbitrary, smaller files.

Edit: Sharding by owning SIGs is a good idea and metric; let's use this issue to track progress on that.

@chases2
Copy link
Contributor

chases2 commented Jul 25, 2019

What goes where is going to vary by SIG, so we'll need to get them involved in the process.

Sharding for a SIG can be done similarly to #13609:

  1. Remove the appropriate Dashboard Groups and Dashboards from the central file
  2. Put them in any file in the /config/testgrids directory tree. Subdirectories are fine, and encouraged in moderation, since OWNERS files can be nested in this way.

/help

@k8s-ci-robot
Copy link
Contributor

@chases2:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What goes where is going to vary by SIG, so we'll need to get them involved in the process.

Sharding for a SIG can be done similarly to #13609:

  1. Remove the appropriate Dashboard Groups and Dashboards from the central file
  2. Put them in any file in the /config/testgrids directory tree. Subdirectories are fine, and encouraged in moderation, since OWNERS files can be nested in this way.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 31, 2019

I've attempted to model what sharding to sig-owned dirs would look like, using the sig-testing and sig-contribex testgrids: #13720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/testgrid help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants