Checkconfig should not expect trigger to be enabled on gerrit repos.

[cjwagner]

What happened:
The checkconfig component expects every repo that specified a job to enable the trigger plugin and it checks this if plugins.yaml is provided. This isn't correct for gerrit repos.

{"component":"checkconfig","file":"prow/cmd/checkconfig/main.go:76","func":"main.reportWarning","level":"warning","msg":"the following repos have jobs configured but do not have the trigger plugin enabled: repo: https://kunit-review.googlesource.com/linux","time":"2019-10-11T23:23:41Z"}

What you expected to happen:
checkconfig should not require trigger to be enabled for gerrit repos. Here is an example gerrit job https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kunit-review.googlesource.com/linux/kunit-linux-config.yaml
I think the only way we can distinguish it as a gerrit job is the url instead of <org>/<repo> format used for GH repos.
/help
/good-first-issue
cc @stevekuznetsov @krzyzacy

[k8s-ci-robot]

@cjwagner:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

What happened:
The checkconfig component expects every repo that specified a job to enable the trigger plugin and it checks this if plugins.yaml is provided. This isn't correct for gerrit repos.

{"component":"checkconfig","file":"prow/cmd/checkconfig/main.go:76","func":"main.reportWarning","level":"warning","msg":"the following repos have jobs configured but do not have the trigger plugin enabled: repo: https://kunit-review.googlesource.com/linux","time":"2019-10-11T23:23:41Z"}

What you expected to happen:
checkconfig should not require trigger to be enabled for gerrit repos. Here is an example gerrit job https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kunit-review.googlesource.com/linux/kunit-linux-config.yaml
I think the only way we can distinguish it as a gerrit job is the url instead of <org>/<repo> format used for GH repos.
/help
/good-first-issue
cc @stevekuznetsov @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hasheddan]

@cjwagner I am happy to take this one!

[hasheddan]

/assign @hasheddan

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[stevekuznetsov]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[e-blackwelder]

I'll look into this.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.