-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Allow pod-utils / clonerefs to use default remote branch #20667
Copy link
Copy link
Open
Labels
area/jobsarea/prow/pod-utilitiesIssues or PRs related to prow's pod-utilities componentIssues or PRs related to prow's pod-utilities componentkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.sig/testingCategorizes an issue or PR as relevant to SIG Testing.Categorizes an issue or PR as relevant to SIG Testing.
Milestone
Metadata
Metadata
Assignees
Labels
area/jobsarea/prow/pod-utilitiesIssues or PRs related to prow's pod-utilities componentIssues or PRs related to prow's pod-utilities componentkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.sig/testingCategorizes an issue or PR as relevant to SIG Testing.Categorizes an issue or PR as relevant to SIG Testing.
Type
Fields
Give feedbackNo fields configured for issues without a type.
My read of current pod-utils code is that it assumes
base_refto always be present / non-empty (ref: #20665 (comment))It looks like there are 435 jobs that explicitly reference
master, when what they likely mean is "just use whatever the default remote branch is"Ideally base_ref would be auto-populated with the remote default branch if omitted. Maybe this already happens? This would make repo default branch renames less toilsome.
Opening this to track verifying or fixing, so not yet a bug or feature.
/area prow/pod-utilities
/assign @alvaroaleman @cjwagner
in case you can answer more quickly than I can, feel free to /unassign if you can't handle
/assign @spiffxp
to verify what happens today