Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all mungers out of mungegithub to prow plugins / periodic jobs #3331

Closed
spiffxp opened this Issue Jul 5, 2017 · 18 comments

Comments

Projects
None yet
10 participants
@spiffxp
Copy link
Member

commented Jul 5, 2017

Umbrella issue.

Most of the mungers can be migrated to Prow plugins and respond to github webhook events but a few need to run periodically without having received an event. These should probably be implemented as kubernetes cron jobs.


EDIT: here's the munger list as of 2018-08-27

munger plan status
approval-handler prow/plugins/approve done (#5115)
assign-fixes no replacement [3] n/a
block-path prow/plugins/blockade done (#4944)
blunderbuss prow/plugins/blunderbuss done (#5547)
check-labels label_sync done
bulk-lgtm remove done (#4101)
cherrypick-auto-approve [1]
cherrypick-clear-after-merge [1]
cherrypick-must-have-milestone [1]
cherrypick-queue [1]
close-stale prow/plugins/lifecycle + cron job done (#5707)
comment-deleter no replacement [2] n/a
docs-need-no-retest prow/plugins/docs-no-retest done (#4895)
flaky-job-reporter robots/issue-creator done (#3970, #4450)
inactive-review-handler no replacement [3] n/a
issue-creator robots/issue-creator done (#3970, #4450)
issue-triager no replacement [3] n/a
label-unapproved-picks prow plugin done (#9128)
lgtm-after-commit external prow plugin done (#6886)
milestone-maintainer prow plugin in-progress (#9158)
needs-rebase external plugin done (#6022)
nag-flake-issues no replacement [3] n/a
old-test-getter no replacement [3] n/a
owner-label prow plugin done (#6033)
path-label prow plugin done (#6033)
publisher kubernetes/publishing-bot done
release-note-label prow/plugins/releasenotes done (#4718)
sig-mention-handler prow/plugins/requiresig done (#5662)
size prow plugin done (#3794, #4157)
stale-green-ci no replacement [4] n/a
stale-pending-ci no replacement [3] n/a
submit-queue prow/cmd/tide in-progress (#3866)
triage-filer robots/issue-creator done (#3970, #4450)

[1] - The cherrypick process on github should be rethought and simplified if possible.
[2] - The comment-deleter is no longer needed if plugins that create comments remove stale comments at that time.
[3] - The assign-fixes, inactive-review-handler, issue-triager, old-test-getter, nag-flake-issues, and stale-pending-ci are no longer in use so shouldn't be migrated unless they are needed.
[4] - The stale-green-ci munger could be reimplemented as a commenter job (eg: periodic-test-infra-retester) but we don't plan on adding this back unless it is sorely missed

@kargakis

This comment has been minimized.

Copy link
Member

commented Jul 29, 2017

Is there an issue for migrating approvals into a prow plugin? Has anybody started working on that? I am interested in pursuing it next week.

@cjwagner

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

I don't think there is an issue specific to that munger yet, just this issue. No one is working on migrating the approval-handler yet, so that would be great!

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2017

discussed during sig-testing today; some mungers can be moved out, some can't (or we'd like to obviate, eg: submit-queue for tide)

will update this issue with a full list

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2017

We've got a migration of docs-only-retest-not-required incoming

@cjwagner cjwagner changed the title Migrate all non-PR mungers out of mungegithub to prow plugins / periodic jobs Migrate all mungers out of mungegithub to prow plugins / periodic jobs Sep 19, 2017

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Sep 29, 2017

@spiffxp I think we can mark off the release note munger (?) :D

@cjwagner

This comment has been minimized.

Copy link
Member

commented Sep 29, 2017

@BenTheElder Just deployed the changes 😄 I'll mark it.

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

#5010 may end up being a suitable replacement for the existing cherry-pick mungers

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2017

Alternatively, it could just continue to create the cherry-pick PR and allow for the current mungers (or their Prow replacements) to layer on top as they had in the past.

@cjwagner

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

The cherry-pick bot doesn't really replace the cherry-pick mungers because the mungers don't handle the creation of cherry-pick PRs.
However, the cherry-pick bot does replace the hack/cherry_pick_pull.sh script and will be much easier to use.

@spiffxp spiffxp modified the milestones: 2017-goals, v1.9 Oct 19, 2017

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2017

/assign @marun
per sig-testing v1.9 roadmap

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 11, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@spiffxp spiffxp modified the milestones: 1.10, 1.11 Apr 11, 2018

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 10, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

/remove-lifecycle stale
The above table has gone stale, I'll update it. The submit queue still exists, so this isn't done yet

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

/milestone 1.12

@nikhita

This comment has been minimized.

Copy link
Member

commented Aug 26, 2018

@spiffxp The table needs an update for label-unapproved-picks. :)

Ref: #9128

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2018

@nikhita done, and thanks again

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2018

/close
We have removed mungegithub #9362

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2018

@spiffxp: Closing this issue.

In response to this:

/close
We have removed mungegithub #9362

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.