New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tide for cloud-provider-sample #10569

Merged
merged 1 commit into from Jan 19, 2019

Conversation

@nikhita
Copy link
Member

nikhita commented Dec 28, 2018

cloud-provider-sample is a new repo in the Kubernetes org: kubernetes/org#314.

This is required for kubernetes/cloud-provider-sample#1 to merge.

/cc @cblecker @spiffxp

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Dec 28, 2018

/cc @tallclair
for node-api

/cc @cheftako
for cloud-provider-sample

@k8s-ci-robot k8s-ci-robot requested review from cheftako and tallclair Dec 28, 2018

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Dec 28, 2018

/hold

Isn’t node-api a staging repo?

@cheftako

This comment has been minimized.

Copy link
Member

cheftako commented Dec 28, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 28, 2018

LGTM label has been added.

Git tree hash: 0bb088bb12042784716dacd07f2ce5be94015317

Enable tide for cloud-provider-sample
This is a new repo created in the Kubernetes org.

@nikhita nikhita force-pushed the nikhita:enable-tide-for-new-repos branch from 61ad2d1 to 0d6768d Dec 30, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 30, 2018

@nikhita nikhita changed the title Enable tide for node-api and cloud-provider-sample repos Enable tide for loud-provider-sample Dec 30, 2018

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Dec 30, 2018

Isn’t node-api a staging repo?

Yes, got confused by seeing client-go in the list 🤦‍♀️ (but client-go is different because it does have some authoritative files in the published repo).

Removed node-api. 👍

@nikhita nikhita changed the title Enable tide for loud-provider-sample Enable tide for cloud-provider-sample Dec 30, 2018

@cheftako
Copy link
Member

cheftako left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 2, 2019

LGTM label has been added.

Git tree hash: c14c19576cfb2cbe0ca4dfacd7073afc76091a29

@cblecker
Copy link
Member

cblecker left a comment

/lgtm
/assign @cjwagner

@cjwagner
Copy link
Member

cjwagner left a comment

/lgtm

@spiffxp Any reason for us to keep listing all the Kubernetes repos individually or can we switch to using org: kubernetes -repo:kubernetes/kubernetes with the excludedRepos field?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cjwagner, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Jan 19, 2019

/hold cancel
Opened #10846 for changing the query

@k8s-ci-robot k8s-ci-robot merged commit 38bfb6c into kubernetes:master Jan 19, 2019

12 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Job succeeded.
Details
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 19, 2019

@nikhita: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

cloud-provider-sample is a new repo in the Kubernetes org: kubernetes/org#314.

This is required for kubernetes/cloud-provider-sample#1 to merge.

/cc @cblecker @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita nikhita deleted the nikhita:enable-tide-for-new-repos branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment