New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move integration and verify job on master onto podutils #10679

Merged
merged 1 commit into from Jan 12, 2019

Conversation

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Jan 10, 2019

will these jobs work as periodics? there's no pull ref, but also no git remotes, right?

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Jan 10, 2019

@ixdy they have KUBE_FORCE_VERIFY_CHECKS on, which will bypass the ref check in places like https://github.com/kubernetes/kubernetes/blob/master/hack/verify-godeps.sh#L25

envs:
- name: KUBE_FORCE_VERIFY_CHECKS
value: "y"
- name: KUBE_VERIFY_GIT_BRANCH

This comment has been minimized.

@cblecker

cblecker Jan 10, 2019

Member

We don't need this set if KUBE_FORCE_VERIFY_CHECKS is set.

This comment has been minimized.

@ixdy

ixdy Jan 10, 2019

Member

unfortunately hack/verify-readonly-packages.sh uses this (and kube::util::has_changes) always:

https://github.com/kubernetes/kubernetes/blob/5647244b0c13db98816c136ad3e7d58551bbd41d/hack/verify-readonly-packages.sh#L28
https://github.com/kubernetes/kubernetes/blob/5647244b0c13db98816c136ad3e7d58551bbd41d/hack/verify-readonly-packages.sh#L47-L52

maybe there's a way to refactor it so it doesn't need KUBE_FORCE_VERIFY_CHECKS? that'd eliminate the issue of not having a remote, too.

This comment has been minimized.

@krzyzacy

krzyzacy Jan 11, 2019

Member

wait.... there's no point to check if the readonly packages are changed in CI right...

This comment has been minimized.

@krzyzacy

krzyzacy Jan 11, 2019

Member

what's the best way to skip a certain verify check? :-)

envs:
- name: KUBE_FORCE_VERIFY_CHECKS
value: "y"
- name: KUBE_VERIFY_GIT_BRANCH

This comment has been minimized.

@cblecker

cblecker Jan 10, 2019

Member

We don't need this set if KUBE_FORCE_VERIFY_CHECKS is set.

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 10, 2019

I'm also concerned with moving to podutils when we're still missing metadata: #10544

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Jan 10, 2019

How about let's generate some metadata, like k8s versions, in the verify/integration scripts?

Kubetest writes out things like k8s versions in podutils, like https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-prow-canary/29637

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Jan 10, 2019

hummmm the godep job did not use the hack/jenkins scripts :-\ wonder if there's a common place I can inject some code? @cblecker

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 10, 2019

runner.sh 😈 ?

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Jan 10, 2019

@cblecker I probably need to run things like hack/lib/version.sh which is... very k8s dependent...

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Jan 11, 2019

/hold
need to set another k/k bash fire

@krzyzacy krzyzacy force-pushed the krzyzacy:hack-ci branch from 47aeb46 to 7acddd3 Jan 12, 2019

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Jan 12, 2019

Gonna move verify only for now given we are still missing metadata, we'll put in some fix for that Monday.

- name: EXCLUDE_TYPECHECK
value: "y"
- name: EXCLUDE_GODEP
value: "y"

This comment has been minimized.

@krzyzacy

krzyzacy Jan 12, 2019

Member

also skipping the checks in the godep job which we missed earlier :-) cc @cblecker

@BenTheElder
Copy link
Member

BenTheElder left a comment

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 12, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

LGTM label has been added.

Git tree hash: df1237964ca3f1c330ee0001d24a6a135951f619

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 12, 2019

Merging pending kubernetes/kubernetes#72842

Will imppement a metadata bandaid in a follow-up, discussed with Sen offline.

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Jan 12, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 709f6e4 into kubernetes:master Jan 12, 2019

12 checks passed

cla/linuxfoundation krzyzacy authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

@krzyzacy: Updated the job-config configmap using the following files:

  • key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml

In response to this:

presubmit version:

https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72542/pull-kubernetes-verify-podutil/24
https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72542/pull-kubernetes-integration-podutil/16

flipped KUBE_FORCE_VERIFY_CHECKS on for CI

/assign @cblecker @ixdy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment