New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label_sync: add wg/component-standard #10690

Merged
merged 1 commit into from Jan 10, 2019

Conversation

@nikhita
Copy link
Member

nikhita commented Jan 10, 2019

@luxas

luxas approved these changes Jan 10, 2019

Copy link
Member

luxas left a comment

Thanks, LGTM except for the comment

@@ -577,6 +577,13 @@ default:
target: both
prowPlugin: label
addedBy: anyone
- color: ee9900

This comment has been minimized.

@luxas

luxas Jan 10, 2019

Member

Should this be here?

This comment has been minimized.

@nikhita

nikhita Jan 10, 2019

Member

gah, bad copy paste. fixed.

@nikhita nikhita force-pushed the nikhita:wg-component-standard branch from 80ef944 to 4e8ff7c Jan 10, 2019

@nikhita nikhita force-pushed the nikhita:wg-component-standard branch from 4e8ff7c to a9b059f Jan 10, 2019

@luxas
Copy link
Member

luxas left a comment

/lgtm
Thanks!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2019

LGTM label has been added.

Git tree hash: c80d44a48f59623a6a9b70ccc71c812a5a825f7c

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Jan 10, 2019

/assign @Katharine
for approval

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Jan 10, 2019

Cancelling the hold since kubernetes/community#3008 merged.

/hold cancel

@Katharine

This comment has been minimized.

Copy link
Member

Katharine commented Jan 10, 2019

I wonder if it'd make sense to make labels.css be generated by bazel at build time. In any case:

/approve
/pony lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2019

@Katharine: pony image

In response to this:

I wonder if it'd make sense to make labels.css be generated by bazel at build time. In any case:

/approve
/pony lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, Katharine, luxas, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1b22d7a into kubernetes:master Jan 10, 2019

12 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2019

@nikhita: Updated the label-config configmap using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Ref: kubernetes/community#3008 (comment)

/hold
until kubernetes/community#3008 is merged

/cc @luxas @sttts @mtaufen
/assign @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment