Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gubernator! #11302

Merged
merged 2 commits into from Feb 27, 2019

Conversation

@Katharine
Copy link
Member

Katharine commented Feb 14, 2019

This PR changes prow and testgrid configuration to point at Prow, and adds a message to the top of Spyglass pages pointing to Gubernator.

This cannot merge before #11274, #11299, #11292 (or similar), #11207, and #11183 have been actually deployed. Most have merged, but are blocked on our ongoing inability to deploy prow.

/assign @BenTheElder @fejta @spiffxp @krzyzacy @cjwagner
/hold

Show resolved Hide resolved prow/config.yaml Outdated
@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Feb 14, 2019

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi Feb 14, 2019

@Katharine Katharine force-pushed the Katharine:deprecate-gubernator branch from 98cd31f to 17fb3a3 Feb 14, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Feb 14, 2019

Will gubernator still be available, but just not be the default?

/hold
Explicit hold as this is a contributor impacting change, and needs to go through the notification/consensus process when it's ready to go.

@Katharine

This comment has been minimized.

Copy link
Member Author

Katharine commented Feb 14, 2019

@cblecker Gubernator will still be available for the forseeable future (though presumably not indefinitely). Spyglass pages will have a banner at the top with a link pointing to the corresponding Gubernator page, something like this:

(the exact wording used is defined in this PR.)

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Feb 14, 2019

@Katharine that looks great! No objections from me.

When we're ready to go with this:

  • We need to send an e-mail to testing, contribex, and k-dev outlining the change to experience, what folks can expect, and where to send feedback.
  • At least 72 hours notice required, more if over a weekend, for feedback/lazy consensus.
  • Then :shipit: !
@fejta
Copy link
Contributor

fejta left a comment

/lgtm
/hold

@@ -42,7 +42,7 @@ import (

var configPath = flag.String("config", "../../../prow/config.yaml", "Path to prow config")
var jobConfigPath = flag.String("job-config", "../../jobs", "Path to prow job config")
var gubernatorPath = flag.String("gubernator-path", "https://gubernator.k8s.io", "Path to linked gubernator")
var deckPath = flag.String("deck-path", "https://prow.k8s.io", "Path to deck")

This comment has been minimized.

@fejta

fejta Feb 15, 2019

Contributor

why is this a flag?

This comment has been minimized.

@Katharine

Katharine Feb 15, 2019

Author Member

¯\_(ツ)_/¯

This comment has been minimized.

@krzyzacy

krzyzacy Feb 15, 2019

Member

@fejta I'm kinda using this test for gerrit jobs as well so...

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 15, 2019

LGTM label has been added.

Git tree hash: 23a86380af1d2b72910261b195910e014506f321

@Katharine

This comment has been minimized.

Copy link
Member Author

Katharine commented Feb 15, 2019

At this point our primary blocker is the fact that we are still unable to deploy Prow. #11292 is only blocked on #11318, and that's the last dependency. Once we finally manage to deploy prow (hopefully by Tuesday?), I intend to send roughly this email:

Hi all!

We have been working on a replacement for Gubernator, which you may know as the page that the "Details" links on GitHub point at.

This replacement, called Spyglass, is now ready for prime time, and we would like to switch all the links to Gubernator to instead be links to Spyglass.

From a user perspective, Spyglass should provide the functionality of Gubernator, but with a hopefully less confusing UI. However, we will keep running Gubernator for the forseeable future, with a link to the corresponding Gubernator page at the top of each Spyglass page.

Spyglass is part of Prow, and enables us to avoid maintaining an extra service for job viewing. It is also designed to be extensible, and in particular open the door for artifact- and job-specific views.

You can try out Spyglass today by clicking the "View in Spyglass" link at the top of Gubernator result pages. Please send general feedback to #sig-testing on Slack.

Do note that this does not affect the PR dashboard at https://gubernator.k8s.io/pr, which we have no current plans to replace and will continue to be supported.

In the absence of any objections, I intend to switch this over for jobs starting on Friday.

Thanks!
- Katharine

@Katharine

This comment has been minimized.

Copy link
Member Author

Katharine commented Feb 19, 2019

All the dependencies are in. Once we actually manage to deploy Prow (today? maybe? hopefully?) I will send that email.

@Katharine

This comment has been minimized.

Copy link
Member Author

Katharine commented Feb 20, 2019

The email has been sent out.

@Katharine Katharine force-pushed the Katharine:deprecate-gubernator branch from 17fb3a3 to 6068002 Feb 25, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 25, 2019

@Katharine

This comment has been minimized.

Copy link
Member Author

Katharine commented Feb 25, 2019

Nobody has objected during the lazy consensus period, so this is good to merge in principle.

Some bugs were reported and have since been fixed, but not yet deployed. In particular, until #11463 and #11466 have merged and been deployed, we probably don't want to merge this.

/hold

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 25, 2019

explicit +1

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

stevekuznetsov commented Feb 26, 2019

@Katharine will my Deck point to My Gubernator for this change?

@@ -37,6 +36,7 @@ deck:
- "buildlog"
"artifacts/junit.*\\.xml":
- "junit"
announcement: "The old job viewer, Gubernator, has been deprecated in favour of this page, Spyglass.{{if .ArtifactPath}}For now, the old page is <a href='https://gubernator.k8s.io/build/{{.ArtifactPath}}'>still available</a>.{{end}} Please send feedback to sig-testing."

This comment has been minimized.

@fejta

fejta Feb 26, 2019

Contributor

Steve you'll need to set this config value to have it link back to your gubernator

Katharine added some commits Feb 14, 2019

@Katharine Katharine force-pushed the Katharine:deprecate-gubernator branch from 6f158ed to dca9480 Feb 26, 2019

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 27, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 27, 2019

LGTM label has been added.

Git tree hash: 69091651db1e3c15714e443a980a5b9261554754

@Katharine

This comment has been minimized.

Copy link
Member Author

Katharine commented Feb 27, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit c982004 into kubernetes:master Feb 27, 2019

14 checks passed

cla/linuxfoundation Katharine authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Job succeeded.
Details
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped.
pull-test-infra-verify-tslint Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 27, 2019

@Katharine: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

This PR changes prow and testgrid configuration to point at Prow, and adds a message to the top of Spyglass pages pointing to Gubernator.

This cannot merge before #11274, #11299, #11292 (or similar), #11207, and #11183 have been actually deployed. Most have merged, but are blocked on our ongoing inability to deploy prow.

/assign @BenTheElder @fejta @spiffxp @krzyzacy @cjwagner
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot referenced this pull request Mar 1, 2019

Merged

Fast forward Prow #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.