Deprecate gubernator! by Katharine · Pull Request #11302 · kubernetes/test-infra

Katharine · 2019-02-14T22:10:28Z

This PR changes prow and testgrid configuration to point at Prow, and adds a message to the top of Spyglass pages pointing to Gubernator.

This cannot merge before #11274, #11299, #11292 (or similar), #11207, and #11183 have been actually deployed. Most have merged, but are blocked on our ongoing inability to deploy prow.

/assign @BenTheElder @fejta @spiffxp @krzyzacy @cjwagner
/hold

oomichi · 2019-02-14T22:23:20Z

/cc @oomichi

cblecker · 2019-02-14T22:42:28Z

Will gubernator still be available, but just not be the default?

/hold
Explicit hold as this is a contributor impacting change, and needs to go through the notification/consensus process when it's ready to go.

Katharine · 2019-02-14T22:48:52Z

@cblecker Gubernator will still be available for the forseeable future (though presumably not indefinitely). Spyglass pages will have a banner at the top with a link pointing to the corresponding Gubernator page, something like this:

(the exact wording used is defined in this PR.)

cblecker · 2019-02-14T23:28:50Z

@Katharine that looks great! No objections from me.

When we're ready to go with this:

We need to send an e-mail to testing, contribex, and k-dev outlining the change to experience, what folks can expect, and where to send feedback.
At least 72 hours notice required, more if over a weekend, for feedback/lazy consensus.
Then !

fejta

/lgtm
/hold

fejta · 2019-02-15T00:05:11Z

 var configPath = flag.String("config", "../../../prow/config.yaml", "Path to prow config")
 var jobConfigPath = flag.String("job-config", "../../jobs", "Path to prow job config")
-var gubernatorPath = flag.String("gubernator-path", "https://gubernator.k8s.io", "Path to linked gubernator")
+var deckPath = flag.String("deck-path", "https://prow.k8s.io", "Path to deck")


why is this a flag?

¯\_(ツ)_/¯

@fejta I'm kinda using this test for gerrit jobs as well so...

k8s-ci-robot · 2019-02-15T00:05:21Z

LGTM label has been added.

Details

Git tree hash: 23a86380af1d2b72910261b195910e014506f321

Katharine · 2019-02-15T21:01:01Z

At this point our primary blocker is the fact that we are still unable to deploy Prow. #11292 is only blocked on #11318, and that's the last dependency. Once we finally manage to deploy prow (hopefully by Tuesday?), I intend to send roughly this email:

Hi all!

We have been working on a replacement for Gubernator, which you may know as the page that the "Details" links on GitHub point at.

This replacement, called Spyglass, is now ready for prime time, and we would like to switch all the links to Gubernator to instead be links to Spyglass.

From a user perspective, Spyglass should provide the functionality of Gubernator, but with a hopefully less confusing UI. However, we will keep running Gubernator for the forseeable future, with a link to the corresponding Gubernator page at the top of each Spyglass page.

Spyglass is part of Prow, and enables us to avoid maintaining an extra service for job viewing. It is also designed to be extensible, and in particular open the door for artifact- and job-specific views.

You can try out Spyglass today by clicking the "View in Spyglass" link at the top of Gubernator result pages. Please send general feedback to #sig-testing on Slack.

Do note that this does not affect the PR dashboard at https://gubernator.k8s.io/pr, which we have no current plans to replace and will continue to be supported.

In the absence of any objections, I intend to switch this over for jobs starting on Friday.

Thanks!
- Katharine

Katharine · 2019-02-19T18:29:42Z

All the dependencies are in. Once we actually manage to deploy Prow (today? maybe? hopefully?) I will send that email.

Katharine · 2019-02-20T21:59:14Z

The email has been sent out.

Katharine · 2019-02-25T19:45:29Z

Nobody has objected during the lazy consensus period, so this is good to merge in principle.

Some bugs were reported and have since been fixed, but not yet deployed. In particular, until #11463 and #11466 have merged and been deployed, we probably don't want to merge this.

/hold

spiffxp · 2019-02-25T20:31:05Z

explicit +1

k8s-ci-robot · 2019-02-26T17:44:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~config/OWNERS~~ [Katharine]
~~prow/OWNERS~~ [Katharine]
~~testgrid/OWNERS~~ [Katharine]
~~triage/OWNERS~~ [Katharine]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stevekuznetsov · 2019-02-26T17:57:06Z

@Katharine will my Deck point to My Gubernator for this change?

fejta · 2019-02-26T19:56:23Z

      - "buildlog"
      "artifacts/junit.*\\.xml":
      - "junit"
+    announcement: "The old job viewer, Gubernator, has been deprecated in favour of this page, Spyglass.{{if .ArtifactPath}}For now, the old page is <a href='https://gubernator.k8s.io/build/{{.ArtifactPath}}'>still available</a>.{{end}} Please send feedback to sig-testing."


Steve you'll need to set this config value to have it link back to your gubernator

spiffxp · 2019-02-27T00:04:08Z

/lgtm

k8s-ci-robot · 2019-02-27T00:04:10Z

LGTM label has been added.

Details

Git tree hash: 69091651db1e3c15714e443a980a5b9261554754

Katharine · 2019-02-27T00:17:13Z

/hold cancel

k8s-ci-robot · 2019-02-27T00:30:46Z

@Katharine: Updated the config configmap in namespace default using the following files:

key config.yaml using file prow/config.yaml

Details

In response to this:

This PR changes prow and testgrid configuration to point at Prow, and adds a message to the top of Spyglass pages pointing to Gubernator.

This cannot merge before #11274, #11299, #11292 (or similar), #11207, and #11183 have been actually deployed. Most have merged, but are blocked on our ongoing inability to deploy prow.

/assign @BenTheElder @fejta @spiffxp @krzyzacy @cjwagner
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2019

k8s-ci-robot assigned BenTheElder, cjwagner, fejta, krzyzacy and spiffxp Feb 14, 2019

k8s-ci-robot requested review from cblecker, spiffxp and stevekuznetsov February 14, 2019 22:10

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2019

oomichi reviewed Feb 14, 2019

View reviewed changes

Comment thread prow/config.yaml Outdated

k8s-ci-robot requested a review from oomichi February 14, 2019 22:23

Katharine force-pushed the deprecate-gubernator branch from 98cd31f to 17fb3a3 Compare February 14, 2019 22:30

k8s-ci-robot added area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2019

fejta reviewed Feb 15, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2019

Katharine force-pushed the deprecate-gubernator branch from 17fb3a3 to 6068002 Compare February 25, 2019 19:43

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019

k8s-ci-robot added the area/triage label Feb 26, 2019

fejta reviewed Feb 26, 2019

View reviewed changes

Katharine added 2 commits February 26, 2019 15:03

Deprecate gubernator.

5677894

Point triage at spyglass too

dca9480

Katharine force-pushed the deprecate-gubernator branch from 6f158ed to dca9480 Compare February 26, 2019 23:07

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2019

k8s-ci-robot merged commit c982004 into kubernetes:master Feb 27, 2019

jetstack-bot mentioned this pull request Mar 1, 2019

Fast forward Prow jetstack/test-infra#263

Merged

fejta mentioned this pull request Jul 2, 2019

Enable spyglass istio/test-infra#1411

Merged

coryrc mentioned this pull request May 13, 2020

Gubernator: Show "needs approval" knative/test-infra#1801

Closed

Conversation

Katharine commented Feb 14, 2019

Uh oh!

Uh oh!

oomichi commented Feb 14, 2019

Uh oh!

cblecker commented Feb 14, 2019

Uh oh!

Katharine commented Feb 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cblecker commented Feb 14, 2019

Uh oh!

fejta left a comment

Choose a reason for hiding this comment

Uh oh!

fejta Feb 15, 2019

Choose a reason for hiding this comment

Uh oh!

Katharine Feb 15, 2019

Choose a reason for hiding this comment

Uh oh!

krzyzacy Feb 15, 2019

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 15, 2019

Uh oh!

Katharine commented Feb 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Katharine commented Feb 19, 2019

Uh oh!

Katharine commented Feb 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Katharine commented Feb 25, 2019

Uh oh!

spiffxp commented Feb 25, 2019

Uh oh!

k8s-ci-robot commented Feb 26, 2019

Uh oh!

stevekuznetsov commented Feb 26, 2019

Uh oh!

fejta Feb 26, 2019

Choose a reason for hiding this comment

Uh oh!

spiffxp commented Feb 27, 2019

Uh oh!

k8s-ci-robot commented Feb 27, 2019

Uh oh!

Katharine commented Feb 27, 2019

Uh oh!

k8s-ci-robot commented Feb 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Katharine commented Feb 14, 2019 •

edited

Loading

Katharine commented Feb 15, 2019 •

edited

Loading

Katharine commented Feb 20, 2019 •

edited

Loading