Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Google Analytics for prow.k8s.io #12030

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
4 participants
@Katharine
Copy link
Member

Katharine commented Apr 2, 2019

No description provided.

@@ -40,6 +40,7 @@ deck:
tide_update_period: 1s
hidden_repos:
- kubernetes-security
google_analytics: UA-82843984-5

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 2, 2019

Member

is this the same analytics account used for the rest of our stuff? cc: @castrojo

This comment has been minimized.

Copy link
@Katharine

Katharine Apr 2, 2019

Author Member

It's the same as the rest of the sig-testing stuff.

@fejta

fejta approved these changes Apr 2, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 2, 2019

LGTM label has been added.

Git tree hash: 1b3f47395581527e2eebce0fe5b1fbd0cf754eb1

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Apr 2, 2019

/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Apr 2, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 8c3d8ff into kubernetes:master Apr 2, 2019

15 checks passed

cla/linuxfoundation Katharine authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Job succeeded.
Details
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-verify-github-spelling Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped.
pull-test-infra-verify-tslint Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 2, 2019

@Katharine: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.