Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically push all variants of all test images #12038

Merged
merged 14 commits into from Apr 3, 2019

Conversation

@Katharine
Copy link
Member

commented Apr 3, 2019

Build and publish all our various test images using Cloud Build, instead of on Googler workstations.

This PR:

  • Includes functional GCB configurations for all images we publish to gcr.io/k8s-testimages from this repo
  • Includes a small go program that adds some convenient functionality on top of gcloud (see readme)
  • Includes a trusted run_if_changed postsubmit job that will push the relevant images as appropriate
  • Defines a new testgrid dashboard for all of the above jobs
  • Refactors all docker-related Makefiles to invoke Cloud Build

In some future PR it would be nice to deduplicate the massive pile of near-identical prowjob yaml, but I think that's an adventure for another time.

Also to be solved in a future PR: updating all the image references regularly.

/cc @fejta

@fejta

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

This is looking pretty sweet!

@fejta

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

I think we should either refactor the makefiles to call cloudbuild (like rules_k8s does) or else provide shell scripts that call cloud build

@Katharine Katharine force-pushed the Katharine:autopush-test-images branch from e3d8518 to 7dcb63e Apr 3, 2019

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/XL labels Apr 3, 2019

@Katharine Katharine changed the title [WIP] Automatically push all variants of all test images Automatically push all variants of all test images Apr 3, 2019

@Katharine

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

I opted to have the makefiles invoke GCB (via my helper tool).

I think this should be ~ready now.

@fejta

fejta approved these changes Apr 3, 2019

Copy link
Contributor

left a comment

Fantastic

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

LGTM label has been added.

Git tree hash: a46f6c642ed5372578d2ff36a857276cb8ebd2ee

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 3, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be8a125 into kubernetes:master Apr 3, 2019

15 checks passed

cla/linuxfoundation Katharine authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Job succeeded.
Details
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-verify-github-spelling Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Skipped.
pull-test-infra-verify-tslint Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

@Katharine: Updated the job-config configmap in namespace default using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Build and publish all our various test images using Cloud Build, instead of on Googler workstations.

This PR:

  • Includes functional GCB configurations for all images we publish to gcr.io/k8s-testimages from this repo
  • Includes a small go program that adds some convenient functionality on top of gcloud (see readme)
  • Includes a trusted run_if_changed postsubmit job that will push the relevant images as appropriate
  • Defines a new testgrid dashboard for all of the above jobs
  • Refactors all docker-related Makefiles to invoke Cloud Build

In some future PR it would be nice to deduplicate the massive pile of near-identical prowjob yaml, but I think that's an adventure for another time.

Also to be solved in a future PR: updating all the image references regularly.

/cc @fejta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.