Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add area/dependency label #12089

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
3 participants
@nikhita
Copy link
Member

nikhita commented Apr 5, 2019

To help identify PRs that touch deps, so that it's easier for dep-approvers to review these until regex is supported in the approve plugin.

/cc @cblecker @dims @cjwagner

Show resolved Hide resolved label_sync/labels.yaml Outdated

@nikhita nikhita force-pushed the nikhita:area-dep branch from 6e442e8 to 49dcbf9 Apr 5, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 5, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 5, 2019

LGTM label has been added.

Git tree hash: 583c4887399c5191c84bdb9caabfb65ac9df20b1

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 651ad49 into kubernetes:master Apr 5, 2019

14 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-verify-github-spelling Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-labels Job succeeded.
Details
pull-test-infra-verify-tslint Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 5, 2019

@nikhita: Updated the label-config configmap in namespace test-pods using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

To help identify PRs that touch deps, so that it's easier for dep-approvers to review these until regex is supported in the approve plugin.

/cc @cblecker @dims @cjwagner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita nikhita deleted the nikhita:area-dep branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.