Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update godeps -> dependencies job #12104

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@cblecker
Copy link
Member

cblecker commented Apr 7, 2019

fixes #12045.

/hold

@k8s-ci-robot k8s-ci-robot requested review from krzyzacy and spiffxp Apr 7, 2019

@cblecker cblecker force-pushed the cblecker:godep-job branch 2 times, most recently from 53f2a53 to 65186ce Apr 7, 2019

@cblecker cblecker force-pushed the cblecker:godep-job branch from 65186ce to 6b499b0 Apr 7, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 9, 2019

/cc @fejta
Would you mind having a look at this? Also, would this migrate the context, or would I manually have to migrate the old context on existing PRs?

@k8s-ci-robot k8s-ci-robot requested a review from fejta Apr 9, 2019

@fejta

fejta approved these changes Apr 9, 2019

Copy link
Contributor

fejta left a comment

/hold
What is the old context?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 9, 2019

LGTM label has been added.

Git tree hash: fe4479e9bc3bdb2a500926341d652cd996a339a6

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 9, 2019

@fejta pull-kubernetes-godeps is the old context.. in this PR, I'm scoping that job just to the old branches that are still using godep (which is why you only see new lines added)

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Apr 9, 2019

Got it, yaml reading is hard

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Apr 9, 2019

Another idea would be to make the new job optional for awhile so PRs have a chance to run them

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 10, 2019

going to attempt this tomorrow morning PT

migratestatus command:

bazel run //maintenance/migratestatus -- --move="pull-kubernetes-godeps" --dest="pull-kubernetes-dependencies" --org=kubernetes --repo=kubernetes --branch-filter=master --github-token-path=${HOME}/.github-token
@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit a7ab83b into kubernetes:master Apr 11, 2019

14 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-verify-github-spelling Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-labels Skipped.
pull-test-infra-verify-tslint Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 11, 2019

@cblecker: Updated the job-config configmap in namespace default using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key godeps.yaml using file ``
  • key dependencies.yaml using file config/jobs/kubernetes/sig-testing/dependencies.yaml

In response to this:

fixes #12045.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the cblecker:godep-job branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.