Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label for User Group Big Data #12131

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
5 participants
@nikhita
Copy link
Member

nikhita commented Apr 9, 2019

@fejta

fejta approved these changes Apr 9, 2019

Copy link
Contributor

fejta left a comment

/hold

name: ug/big-data
target: both
prowPlugin: label
addedBy: anyone

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 9, 2019

Member

Can you add a previously for sig/big-data to this?

This comment has been minimized.

Copy link
@nikhita

nikhita Apr 9, 2019

Author Member

Done. Also added deleteAfter for sig/big-data.

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 9, 2019

Member

Actually, just remove the whole label section for sig/big-data. We don't want to delete the label. It'll be auto migrated.

@nikhita nikhita force-pushed the nikhita:ug-big-data branch from 32ce494 to 125730a Apr 9, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Apr 9, 2019

@erikerlandson

This comment has been minimized.

Copy link

erikerlandson commented Apr 9, 2019

lgtm (non-binding)

@nikhita nikhita force-pushed the nikhita:ug-big-data branch from 125730a to 699e537 Apr 9, 2019

@cblecker
Copy link
Member

cblecker left a comment

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Apr 9, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 9, 2019

LGTM label has been added.

Git tree hash: ca32871bc1aa8f1d77eaf1f151b9e263b5978ac7

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ef11dec into kubernetes:master Apr 9, 2019

14 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-verify-github-spelling Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-labels Job succeeded.
Details
pull-test-infra-verify-tslint Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 9, 2019

@nikhita: Updated the label-config configmap in namespace test-pods using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Ref: kubernetes/community#3304

/assign @cblecker
cc @erikerlandson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.