Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable project plugin for test-infra #12292

Merged
merged 1 commit into from Apr 22, 2019
Merged

Enable project plugin for test-infra #12292

merged 1 commit into from Apr 22, 2019

Conversation

taragu
Copy link
Contributor

@taragu taragu commented Apr 20, 2019

Testing prow project plugin: #10982
/cc @stevekuznetsov
/cc @cblecker

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2019
@cblecker
Copy link
Member

/hold
Let's wait until next week to merge this when folks are around.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2019
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@taragu go ahead and /hold cancel after 9a PDT

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 979a1f2d5642d395be74a6399ac8f787346dd2af

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, taragu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2019
@taragu
Copy link
Contributor Author

taragu commented Apr 22, 2019

Thanks @stevekuznetsov !
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6a42a76 into kubernetes:master Apr 22, 2019
@k8s-ci-robot
Copy link
Contributor

@taragu: Updated the plugins configmap in namespace default using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

Testing prow project plugin: #10982
/cc @stevekuznetsov
/cc @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taragu @cblecker @stevekuznetsov @k8s-ci-robot