Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mermaid and SVG for Common Interactions Sequence Diagram #12308

Conversation

Projects
None yet
3 participants
@midnightconman
Copy link
Contributor

commented Apr 22, 2019

/kind documentation

This PR adds a definition file (in mermaid) for a simple and common interactions flow of an example pull request submission. Please let me know what you guys think.

/cc @stevekuznetsov @fejta

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Hi @midnightconman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@midnightconman

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Is there a way to force docs-no-retest, this PR doesn't need to be tested in my opinion.

@@ -8,6 +8,8 @@ not make any attempt to preserve backwards compatibility.

For a brief overview of how Prow runs jobs take a look at ["Life of a Prow Job"](/prow/life_of_a_prow_job.md).

For a sequence diagram of common usage and interactions flow, click [here](/prow/docs/pr-interactions-sequence.svg).

This comment has been minimized.

Copy link
@midnightconman

midnightconman Apr 23, 2019

Author Contributor

I see what you mean... let me try a link to the raw with sanitize on.

This comment has been minimized.

Copy link
@midnightconman

midnightconman Apr 23, 2019

Author Contributor

I updated the link to raw for master, to see what it looks like on this commitish, use this link: https://raw.githubusercontent.com/kubernetes/test-infra/d7eadcf7f89bd227b5175a356e413e8bebf3fce0/prow/docs/pr-interactions-sequence.svg?sanitize=true

@fejta

fejta approved these changes Apr 23, 2019

Copy link
Contributor

left a comment

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

LGTM label has been added.

Git tree hash: 7379eac3f614d4adabbf48c4ed5ef1057acec336

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, midnightconman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c31134 into kubernetes:master Apr 23, 2019

14 checks passed

cla/linuxfoundation midnightconman authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-verify-github-spelling Job succeeded.
Details
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-labels Skipped.
pull-test-infra-verify-tslint Skipped.
tide In merge pool.
Details

@midnightconman midnightconman deleted the midnightconman:interactions-sequence-diagrams-20190422 branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.