Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable welcome plugin on all orgs #12593

Merged
merged 1 commit into from May 17, 2019

Conversation

@cblecker
Copy link
Member

commented May 11, 2019

The plugin was configured everywhere, but not enabled by default. This does that.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

/hold

@fejta

fejta approved these changes May 14, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label May 14, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

LGTM label has been added.

Git tree hash: 68acea9a1f2a739cee5930f454a3ac4644e05d51

@nikhita
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@guineveresaenger

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

awesome! we can cancel the hold of you like!

@nikhita

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@cblecker cblecker force-pushed the cblecker:welcome-everywhere branch from 3943d5b to bc3c3a9 May 17, 2019

@nikhita

This comment has been minimized.

Copy link
Member

commented May 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 17, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

LGTM label has been added.

Git tree hash: 51c2e06dc8c5e42da7088a261c682bbd4f001879

@cblecker

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit f1d4d96 into kubernetes:master May 17, 2019

6 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

@cblecker: Updated the plugins configmap in namespace default using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

The plugin was configured everywhere, but not enabled by default. This does that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the cblecker:welcome-everywhere branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.