Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cblecker to prow owners #12853

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@cblecker
Copy link
Member

commented Jun 3, 2019

I know prow stuff. I know what is acceptable to merge, and what needs further review/attention before it can be safely merged. I would like to approve prow things.

/assign @cjwagner @fejta @stevekuznetsov

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/lgtm

for consensus:
/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

LGTM label has been added.

Git tree hash: 5f2660a4bce4a95daad9024ac138bf8634930aa9

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 3, 2019

@cjwagner
Copy link
Member

left a comment

/meow

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@cjwagner: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

👍
/pony approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@krzyzacy: Couldn't find a pony matching that query.

In response to this:

👍
/pony approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta

fejta approved these changes Jun 3, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cjwagner, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

/hold cancel

Thanks all :)

@k8s-ci-robot k8s-ci-robot merged commit 53cdc9e into kubernetes:master Jun 3, 2019

6 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:prow-owners branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.