Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of GitHub API Readme #12953

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@chases2
Copy link
Contributor

commented Jun 7, 2019

A short description of the client to encourage reuse
Addresses #12760

@chases2

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@k8s-ci-robot k8s-ci-robot requested a review from stevekuznetsov Jun 7, 2019

@cblecker
Copy link
Member

left a comment

one nit that helps with markdown formatting

Show resolved Hide resolved prow/github/README.md Outdated
@fejta

fejta approved these changes Jun 10, 2019

Copy link
Contributor

left a comment

/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

LGTM label has been added.

Git tree hash: 805bd7d468250a6a5d1b670c565d50ab75355980

Addition of GitHub API Readme
A short description of the client to encourage reuse
Addresses #12760

@chases2 chases2 force-pushed the chases2:document-github branch from 1eef9df to 2d75e5e Jun 10, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 10, 2019

@chases2

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

I've taken the suggestion from @cblecker
/hold cancel

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

LGTM label has been added.

Git tree hash: 8671a6cc889cb590da2bbd608649b6ad4a65e676

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, chases2, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bd4818e into kubernetes:master Jun 10, 2019

5 of 6 checks passed

tide Not mergeable.
Details
cla/linuxfoundation chases2 authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details

@chases2 chases2 deleted the chases2:document-github branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.