Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retitle plugin for k-sigs/contributor-playground #12964

Merged

Conversation

Projects
None yet
4 participants
@nikhita
Copy link
Member

commented Jun 10, 2019

The plugin was added in #12945 and requires a prow bump to work.
Once we verify on contributor-playground, we can enable it across all orgs.

/cc @stevekuznetsov
/assign @cblecker

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

You'll want #12965 as well -- the current impl is borken :|

@nikhita

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

LGTM label has been added.

Git tree hash: e429cc5ddfa9394cb923d337b9b97640df932832

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

prow was bumped in #12963, cancelling the hold

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 1a71afd into kubernetes:master Jun 11, 2019

6 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@nikhita: Updated the plugins configmap in namespace default using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

The plugin was added in #12945 and requires a prow bump to work.
Once we verify on contributor-playground, we can enable it across all orgs.

/cc @stevekuznetsov
/assign @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita nikhita deleted the nikhita:reititle-contributor-playground branch Jun 11, 2019

@nikhita

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

Test run looks good here: kubernetes-sigs/contributor-playground#289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.