Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send select fields to edit API calls #12965

Merged

Conversation

Projects
None yet
4 participants
@stevekuznetsov
Copy link
Contributor

commented Jun 10, 2019

While the fields that the edit API call accepts are similar to and a
subset of the fields in the larger API response for an issue or PR, the
API expects only a subset of fields on the edit call.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/assign @nikhita
/cc @petr-muller @droslean

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@stevekuznetsov: GitHub didn't allow me to request PR reviews from the following users: petr-muller.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

While the fields that the edit API call accepts are similar to and a
subset of the fields in the larger API response for an issue or PR, the
API expects only a subset of fields on the edit call.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/assign @nikhita
/cc @petr-muller @droslean

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Only send select fields to edit API calls
While the fields that the edit API call accepts are similar to and a
subset of the fields in the larger API response for an issue or PR, the
API expects only a subset of fields on the edit call.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>

@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/fix-issue-edit branch from c963e88 to a71a533 Jun 10, 2019

@nikhita
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

LGTM label has been added.

Git tree hash: fe7ab8ae9a6d105f68ea87827260d42b42faeb88

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ed4626 into kubernetes:master Jun 10, 2019

6 checks passed

cla/linuxfoundation stevekuznetsov authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.