Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel formatting? Question mark? #13038

Merged

Conversation

@stevekuznetsov
Copy link
Contributor

commented Jun 14, 2019

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/assign @fejta @ixdy @cjwagner
/cc @nikhita @cblecker @hongkailiu

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

The job we cared about is not starting due to #13039
/test pull-test-infra-bazel

Update bazel formatting? Question mark?
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>

@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/update-bazel branch from 410c774 to eb9a1d6 Jun 14, 2019

@cblecker
Copy link
Member

left a comment

/lgtm
/approve
/hold

Ship it? Question mark?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

LGTM label has been added.

Git tree hash: a4ef794fa5bca7295d2b117bb207b7b6a6ce52c5

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 3b4958c into kubernetes:master Jun 14, 2019

5 of 6 checks passed

tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation stevekuznetsov authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.