Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
sig-release: Blockade changes to critical k/release tooling #13328
referenced this pull request
Jul 4, 2019
@cblecker -- This is essentially saying I want explicit approval from a repo admin (SIG Release Chair) before changing one of these tools. We have top-level approvers in k/release that I still want to be able to approve other changes without impact.
As the tools are scattered across the repo, I need an extra gate to protect them and I heard that
Sounds like using
I started writing something up and then apparently closed the tab
Basically, I still feel like this is an anti-pattern (blockading files, and then manually removing the label each time you need to change them). It provides a different contributing structure than normal, and requires manual intervention.
I could be convinced to be okay with this for a limited period of time to help stabilize the situation (30d?). Ultimately though, reorganizing files (either move the scripts all together, or move the other stuff all together) and then using OWNERS files should be the goal.
@cblecker -- yep, the intent for the blockade is definitely temporary!
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Jul 9, 2019
@justaugustus: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.