Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support health check of nginx #13365

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@hongkailiu
Copy link
Contributor

commented Jul 9, 2019

@hongkailiu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@hongkailiu hongkailiu force-pushed the hongkailiu:nginxContainerName branch from 7655dcf to 8f417c1 Jul 9, 2019

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

/lgtm
/approve
/hold

Holding for deployment.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

LGTM label has been added.

Git tree hash: f83dfb53870aaeb624a66b7a315501cfe72d8362

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 6f0a037 into kubernetes:master Jul 9, 2019

6 checks passed

cla/linuxfoundation hongkailiu authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@stevekuznetsov

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

$ KUBECONFIG=~/.kube/prow bazel run //prow/monitoring:production.apply
DEBUG: /home/stevekuznetsov/.cache/bazel/_bazel_stevekuznetsov/b470984fd2838346154ef4c1e31b67ca/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:9: rbe_default not using checked in configs; Bazel version 0.27.1 was picked/selected but no checked in config was found in map {"0.20.0": ["8.0.0"], "0.21.0": ["8.0.0"], "0.22.0": ["8.0.0", "9.0.0"], "0.23.0": ["8.0.0", "9.0.0"], "0.23.1": ["8.0.0", "9.0.0"], "0.23.2": ["9.0.0"], "0.24.0": ["9.0.0"], "0.24.1": ["9.0.0"], "0.25.0": ["9.0.0"], "0.25.1": ["9.0.0"], "0.25.2": ["9.0.0"], "0.26.0": ["9.0.0"], "0.26.1": ["9.0.0"], "0.27.0": ["9.0.0"]}
INFO: Analyzed target //prow/monitoring:production.apply (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //prow/monitoring:production.apply up-to-date:
  bazel-bin/prow/monitoring/production.apply
INFO: Elapsed time: 1.422s, Critical Path: 0.36s
INFO: 11 processes: 11 linux-sandbox.
INFO: Build completed successfully, 14 total actions
INFO: Build completed successfully, 14 total actions
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
namespace/prow-monitoring configured
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
clusterrolebinding.rbac.authorization.k8s.io/prow-prometheus-operator configured
clusterrole.rbac.authorization.k8s.io/prow-prometheus-operator configured
serviceaccount/prometheus-operator unchanged
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
deployment.apps/prometheus-operator configured
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
servicemonitor.monitoring.coreos.com/prometheus unchanged
servicemonitor.monitoring.coreos.com/alertmanager unchanged
servicemonitor.monitoring.coreos.com/grafana unchanged
servicemonitor.monitoring.coreos.com/deck unchanged
servicemonitor.monitoring.coreos.com/ghproxy unchanged
servicemonitor.monitoring.coreos.com/hook unchanged
servicemonitor.monitoring.coreos.com/plank unchanged
servicemonitor.monitoring.coreos.com/sinker unchanged
servicemonitor.monitoring.coreos.com/tide unchanged
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
serviceaccount/prometheus-prow unchanged
clusterrolebinding.rbac.authorization.k8s.io/prometheus-prow configured
clusterrole.rbac.authorization.k8s.io/prometheus-prow configured
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
prometheus.monitoring.coreos.com/prow unchanged
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
service/prometheus unchanged
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
serviceaccount/grafana unchanged
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
service/grafana unchanged
ingress.extensions/grafana unchanged
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
configmap/grafana-nginx configured
configmap/grafana-datasources unchanged
configmap/grafana-config unchanged
configmap/grafana-dashboards unchanged
configmap/grafana-dashboard-prow unchanged
configmap/grafana-dashboard-deck unchanged
configmap/grafana-dashboard-ghproxy unchanged
configmap/grafana-dashboard-hook unchanged
configmap/grafana-dashboard-plank unchanged
configmap/grafana-dashboard-sinker unchanged
configmap/grafana-dashboard-tide unchanged
$ /home/stevekuznetsov/google-cloud-sdk/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
deployment.apps/grafana configured
@hongkailiu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Oh G! It works now.
http redirects to https except for http://monitoring.prow.k8s.io/healthy whose response is ok! with 200.

https://ibb.co/JckBpw5

@hongkailiu hongkailiu deleted the hongkailiu:nginxContainerName branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.