Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct conformance image test job image and fork for 1.15 #13687

Merged

Conversation

@BenTheElder
Copy link
Member

commented Jul 30, 2019

I noticed this job failing because this job uses the -master image even for v1.14 and picked up the upgraded bazel version... this fixes that and adds a 1.15 jobs

I don't know how to use the config forker for this properly yet and don't have much time to devote to these at the moment so I'd appreciate a follow up setting that up here.

cc @dims @johnSchnake

@@ -88,7 +88,48 @@ periodics:
description: Runs conformance tests using image against latest kubernetes master with a kubernetes-in-docker cluster
testgrid-alert-email: davanum@gmail.com
testgrid-num-columns-recent: '3'
- interval: 1h
- interval: 3h

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Jul 30, 2019

Author Member

I also reduced the frequency of these older jobs, these take more than an hour to complete and the release branches are not constantly receiving merges to those branches. Not sure if this is the right value though

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

rebase?

@BenTheElder BenTheElder force-pushed the BenTheElder:conformance-image-right-image branch 2 times, most recently from 3e7e23f to d8b207b Aug 2, 2019

@@ -88,7 +88,48 @@ periodics:
description: Runs conformance tests using image against latest kubernetes master with a kubernetes-in-docker cluster
testgrid-alert-email: davanum@gmail.com
testgrid-num-columns-recent: '3'
- interval: 1h
- interval: 3h
name: ci-kubernetes-conformance-image-test-1-15-test

This comment has been minimized.

Copy link
@cblecker

cblecker Aug 2, 2019

Member
Suggested change
name: ci-kubernetes-conformance-image-test-1-15-test
name: ci-kubernetes-conformance-image-1-15-test

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Aug 2, 2019

Author Member

/shrug sure, I just followed the existing pattern

This comment has been minimized.

Copy link
@cblecker

cblecker Aug 2, 2019

Member

No, that extra test- is not in the 1-14 test on L133

@BenTheElder BenTheElder force-pushed the BenTheElder:conformance-image-right-image branch from d8b207b to d094e26 Aug 2, 2019

@BenTheElder BenTheElder force-pushed the BenTheElder:conformance-image-right-image branch from d094e26 to dafef15 Aug 2, 2019

@@ -88,7 +88,48 @@ periodics:
description: Runs conformance tests using image against latest kubernetes master with a kubernetes-in-docker cluster
testgrid-alert-email: davanum@gmail.com
testgrid-num-columns-recent: '3'
- interval: 1h
- interval: 3h
name: ci-kubernetes-conformance-image-test-test-15

This comment has been minimized.

Copy link
@cblecker

cblecker Aug 2, 2019

Member

Still not matching the 1-14 job below

Suggested change
name: ci-kubernetes-conformance-image-test-test-15
name: ci-kubernetes-conformance-image-1-15-test

@BenTheElder BenTheElder force-pushed the BenTheElder:conformance-image-right-image branch from dafef15 to ac8981f Aug 2, 2019

@spiffxp

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 5, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

LGTM label has been added.

Git tree hash: 687863a45045d4f7d3c90db12e465ba7b195428a

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0598201 into kubernetes:master Aug 5, 2019

6 checks passed

cla/linuxfoundation BenTheElder authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

@BenTheElder: Updated the job-config configmap in namespace default using the following files:

  • key conformance-e2e.yaml using file config/jobs/kubernetes/sig-testing/conformance-e2e.yaml

In response to this:

I noticed this job failing because this job uses the -master image even for v1.14 and picked up the upgraded bazel version... this fixes that and adds a 1.15 jobs

I don't know how to use the config forker for this properly yet and don't have much time to devote to these at the moment so I'd appreciate a follow up setting that up here.

cc @dims @johnSchnake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 5, 2019

@BenTheElder BenTheElder deleted the BenTheElder:conformance-image-right-image branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.