Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Kubernetes-specific cherry-pick message to plugin config #14275

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@cblecker
Copy link
Member

commented Sep 10, 2019

No description provided.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

@fejta
fejta approved these changes Sep 10, 2019
@justaugustus

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/hold

@justaugustus
Copy link
Member

left a comment

Thanks for this, @cblecker!
Can you copy in the language from #13148?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 10, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Sep 10, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

/hold

@justaugustus
Copy link
Member

left a comment

I think the backticks and + are going to act weird.

prow/plugins.yaml Outdated Show resolved Hide resolved

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker cblecker force-pushed the cblecker:cherry-pick-config branch from a094365 to d603d83 Sep 10, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Okay, forrealsies this time...
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Sep 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

LGTM label has been added.

Git tree hash: d36253d0c7960225fa39572637ac61645c4a8225

@k8s-ci-robot k8s-ci-robot merged commit 1a37025 into kubernetes:master Sep 10, 2019

5 of 6 checks passed

tide Not mergeable.
Details
cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped.
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

@cblecker: Updated the plugins configmap in namespace default using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 10, 2019

@cblecker cblecker deleted the cblecker:cherry-pick-config branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.