Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goose plugin #14587

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@cblecker
Copy link
Member

commented Oct 3, 2019

I blame @ixdy.

cc: @BenTheElder @vllry

$ go test -v ./prow/plugins/goose/... --human --key-path=api-key
=== RUN   TestRealGoose

![goose image](https://images.unsplash.com/photo-1560850262-408d74ecd8d5?ixlib=rb-1.2.1&q=80&fm=jpg&crop=entropy&cs=tinysrgb&w=400&fit=max&ixid=eyJhcHBfaWQiOjk0MjU3fQ)
--- PASS: TestRealGoose (2.73s)
=== RUN   TestUrl
--- PASS: TestUrl (0.00s)
=== RUN   TestFormat
--- PASS: TestFormat (0.00s)
=== RUN   TestHttpResponse
--- PASS: TestHttpResponse (0.00s)
=== RUN   TestGeese
--- PASS: TestGeese (0.00s)
PASS
ok      k8s.io/test-infra/prow/plugins/goose    3.609s
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

/hold
Holding for review

@k8s-ci-robot k8s-ci-robot requested review from Katharine and krzyzacy Oct 3, 2019
@cblecker cblecker force-pushed the cblecker:HONK branch from d6be68a to 0bbe249 Oct 3, 2019
@vllry

This comment has been minimized.

Copy link

commented Oct 3, 2019

This is my "culture impact" at work.

@justaugustus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Extra points for the branch name!
HONK
/honk untitled

@vllry

This comment has been minimized.

Copy link

commented Oct 3, 2019

I just realized.

Prow is the goose.

Test failure comments are its honks.

@cblecker cblecker force-pushed the cblecker:HONK branch from 0bbe249 to 1cba09a Oct 3, 2019
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

@vllry steals your mouse

Copy link
Member

left a comment

🎉 🎉 🎉

prow/plugins/goose/goose.go Outdated Show resolved Hide resolved
prow/plugins/goose/goose_test.go Outdated Show resolved Hide resolved
@cblecker cblecker force-pushed the cblecker:HONK branch from 1cba09a to f6e0417 Oct 3, 2019
@onlydole

This comment has been minimized.

Copy link

commented Oct 3, 2019

Oh wow - this is a masterpiece 😂

@ixdy

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

For real goose-y behavior, I feel like this should also randomly (with fairly low probability) instead close your PR. :)

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

@ixdy or run an alpha features test that is guaranteed to honk at you

@justaugustus

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

@fejta and I were dismayed to find this hadn't merged yet: #14667 (comment)

/priority critical-urgent
/honk

Copy link
Contributor

left a comment

Glorious 🦆 📢 🙉

g.lock.RLock()
defer g.lock.RUnlock()
uri := string(g.url)
if g.key != "" {

This comment has been minimized.

Copy link
@fejta

fejta Oct 8, 2019

Contributor

Do you have an access key we can put in the cluster? It doesn't look like https://api.unsplash.com/photos/random?query=goose works incognito

This comment has been minimized.

Copy link
@fejta

fejta Oct 9, 2019

Contributor

Okay I have the info I need (and I'm oncall tomorrow), will work on getting this setup.

@fejta
fejta approved these changes Oct 10, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

/hold cancel
:shipit:

@k8s-ci-robot k8s-ci-robot merged commit 78fe9fe into kubernetes:master Oct 10, 2019
5 checks passed
5 checks passed
cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 10, 2019
@cblecker cblecker deleted the cblecker:HONK branch Oct 10, 2019
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

📣 #14691

@ixdy

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/honk

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

@ixdy:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

@BenTheElder:
goose image

In response to this:

/honk

On Thu, Oct 10, 2019, 15:09 Kubernetes Prow Robot notifications@github.com
wrote:

@ixdy https://github.com/ixdy:
[image: goose image]
https://camo.githubusercontent.com/c13c102f97acdf0c5bb42c98678e982cdf3397e1/68747470733a2f2f696d616765732e756e73706c6173682e636f6d2f70686f746f2d313535373835383832392d3439396265363435636266363f69786c69623d72622d312e322e3126713d383026666d3d6a70672663726f703d656e74726f70792663733d74696e797372676226773d343030266669743d6d617826697869643d65794a6863484266615751694f6a6b304d6a55336651

In response to this
#14587 (comment)
:

/honk

Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:
repository.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/pull/14587?email_source=notifications&email_token=AAHADKZOX7ZBK6U5GCHHGSLQN6RZRA5CNFSM4I46JJT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA6EF5Q#issuecomment-540820214,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHADKY7ILG3HDUSGFHRVMTQN6RZRANCNFSM4I46JJTQ
.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/honk

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

@mrbobbytables:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Pensu

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

/honk

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

@Pensu:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.