Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prow jobs for alibaba cloud csi driver #15009

Conversation

@haoshuwei
Copy link
Member

haoshuwei commented Oct 29, 2019

fix issue #15008
Signed-off-by: haoshuwei haoshuwei24@gmail.com

@k8s-ci-robot k8s-ci-robot requested review from cblecker and chases2 Oct 29, 2019
@haoshuwei haoshuwei force-pushed the haoshuwei:add-prowjobs-alibaba-cloud-csi-driver branch 2 times, most recently from a88d9df to 5b02b83 Oct 29, 2019
@haoshuwei haoshuwei force-pushed the haoshuwei:add-prowjobs-alibaba-cloud-csi-driver branch 4 times, most recently from d8eba24 to 9d333fe Oct 29, 2019
@fredkan

This comment has been minimized.

Copy link
Member

fredkan commented Oct 29, 2019

lgtm

@chases2

This comment has been minimized.

Copy link
Contributor

chases2 commented Nov 2, 2019

/lgtm

testgrid-tab-name: pr-verify-vet
description: Vets the Golang sources have been vetted

- name: pull-alibaba-cloud-csi-driver-verify-ut

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 2, 2019

Member

We usually just call these unit

Suggested change
- name: pull-alibaba-cloud-csi-driver-verify-ut
- name: pull-alibaba-cloud-csi-driver-verify-unit
Signed-off-by: haoshuwei <haoshuwei24@gmail.com>
@haoshuwei haoshuwei force-pushed the haoshuwei:add-prowjobs-alibaba-cloud-csi-driver branch from 9d333fe to 0c83701 Nov 14, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 14, 2019
@haoshuwei

This comment has been minimized.

Copy link
Member Author

haoshuwei commented Nov 14, 2019

@cblecker sorry for the late reply, i have updated xxx-ut to xxx-unit instead.

@haoshuwei haoshuwei referenced this pull request Nov 14, 2019
@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Nov 14, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, haoshuwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e3e0111 into kubernetes:master Nov 14, 2019
4 of 5 checks passed
4 of 5 checks passed
tide Not mergeable. Retesting: pull-test-infra-bazel
Details
cla/linuxfoundation haoshuwei authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2019

@haoshuwei: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key alibaba-cloud-csi-driver.yaml using file config/jobs/kubernetes-sigs/alibaba-cloud-csi-driver/alibaba-cloud-csi-driver.yaml

In response to this:

fix issue #15008
Signed-off-by: haoshuwei haoshuwei24@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.