Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sig-cloudprovider-apiserver-network-proxy job and dashboard #15011

Merged
merged 3 commits into from Nov 1, 2019

Conversation

@Sh4d1
Copy link
Contributor

Sh4d1 commented Oct 29, 2019

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

In order to set annotations on jobs #14973 cc @cblecker

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 29, 2019

Hi @Sh4d1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from chases2 and cheftako Oct 29, 2019
@Sh4d1 Sh4d1 force-pushed the Sh4d1:kas-network-proxy_dashboard branch from 9f9fbac to b242513 Oct 29, 2019
@Sh4d1 Sh4d1 changed the title add sig-cloudprovider-kas-network-proxy dashboard add sig-cloudprovider-apiserver-network-proxy dashboard Oct 29, 2019
@Sh4d1

This comment has been minimized.

Copy link
Contributor Author

Sh4d1 commented Oct 29, 2019

/assign @justaugustus

Copy link
Member

justaugustus left a comment

@Sh4d1 -- Made a few code suggestions on the dashboard and group names.
Would you mind making those changes and then combining this commit with #14973, so we can approve it at once?

@Sh4d1 Sh4d1 force-pushed the Sh4d1:kas-network-proxy_dashboard branch from b242513 to 8553c76 Oct 31, 2019
@k8s-ci-robot k8s-ci-robot removed the size/XS label Oct 31, 2019
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@k8s-ci-robot k8s-ci-robot added the size/M label Oct 31, 2019
Sh4d1 added 2 commits Oct 29, 2019
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@Sh4d1 Sh4d1 force-pushed the Sh4d1:kas-network-proxy_dashboard branch from 8553c76 to 3b71c0e Oct 31, 2019
@Sh4d1

This comment has been minimized.

Copy link
Contributor Author

Sh4d1 commented Oct 31, 2019

@justaugustus fixed :)

@Sh4d1 Sh4d1 changed the title add sig-cloudprovider-apiserver-network-proxy dashboard add sig-cloudprovider-apiserver-network-proxy job and dashboard Oct 31, 2019
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Oct 31, 2019

Thanks @Sh4d1!
/lgtm
/approve
/assign @cblecker @krzyzacy

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 31, 2019
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Oct 31, 2019

/ok-to-test

@Sh4d1

This comment has been minimized.

Copy link
Contributor Author

Sh4d1 commented Oct 31, 2019

/assign @wojtek-t

Copy link
Member

cheftako left a comment

/lgtm
Thanks you

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus, Sh4d1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9e8f6e5 into kubernetes:master Nov 1, 2019
5 checks passed
5 checks passed
cla/linuxfoundation Sh4d1 authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 1, 2019

@Sh4d1: Updated the job-config configmap in namespace default using the following files:

  • key apiserver-network-proxy-presubmits.yaml using file config/jobs/kubernetes-sigs/apiserver-network-proxy/apiserver-network-proxy-presubmits.yaml

In response to this:

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

In order to set annotations on jobs #14973 cc @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.