Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-release: Rearrange dash configs and prune some jobs from sig-release-job-config-errors #15068

Merged
merged 3 commits into from Nov 5, 2019

Conversation

@justaugustus
Copy link
Member

justaugustus commented Nov 2, 2019

This continues the pruning work I started in #15039.

Here we're doing a few things:

  • Add sig-release-generated dashboard to allow us to easily identify generated tests
  • Allow kubernetes-bazel-build jobs to fork into release dashes by moving them to *-informing
  • Drop kops and Windows jobs from job-config-errors dash
  • Drop GCE/GKE jobs from job-config-errors dash

The remaining jobs on the sig-release-job-config-errors are in config/jobs/kubernetes/sig-cli/sig-cli-config.yaml.

Several of them seem to be passing, but are incorrect named e.g., 1.12-1.13 when they're using something like stable1/stable2 markers
There are enough of them configured in confusing ways, that I'd like to tackle them in a separate PR.

@@ -123,35 +123,6 @@ postsubmits:
testgrid-dashboards: sig-release-master-informing
testgrid-tab-name: bazel-build-master
description: 'OWNER: sig-testing; Builds kubernetes at each bommit using bazel with RBE'
- name: ci-kubernetes-bazel-test # TODO(fejta): delete after 1m (dup of post-kubernetes-bazel-test)

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 2, 2019

Author Member

Dropping this as @fejta left the TODO in May.

@fejta
fejta approved these changes Nov 2, 2019
Copy link
Contributor

fejta left a comment

/hold

@justaugustus justaugustus changed the title [WIP] sig-release: Rearrange dash configs sig-release: Rearrange dash configs and prune some jobs from sig-release-job-config-errors Nov 2, 2019
@justaugustus

This comment has been minimized.

@justaugustus justaugustus added this to Review in progress in Release Engineering Nov 2, 2019
@@ -369,7 +369,7 @@ periodics:
postsubmits:
kubernetes/kubernetes:
- annotations:
testgrid-dashboards: sig-release-job-config-errors
testgrid-dashboards: google-unit, sig-release-1.14-informing

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 2, 2019

Member

I think this job is misnamed on L379

@@ -383,7 +383,7 @@ periodics:
postsubmits:
kubernetes/kubernetes:
- annotations:
testgrid-dashboards: sig-release-job-config-errors
testgrid-dashboards: google-unit, sig-release-1.15-informing
branches:

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 2, 2019

Member

I'm confused.. are these postsubmits or periodics?

justaugustus added 3 commits Nov 1, 2019
Differentiate jobs using experiment/generate_tests.py from jobs that
appear to be manually misconfigured. We'll need to work on fixing both,
but it's worthwhile to separate the two.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus force-pushed the justaugustus:rearrange-dash-configs branch from c567c7f to c196a1a Nov 5, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 5, 2019
@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Nov 5, 2019

(dropped the bazel job changes to make this less controversial.)
/assign @Katharine @cblecker

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 5, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, justaugustus, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus

This comment has been minimized.

Copy link
Member Author

justaugustus commented Nov 5, 2019

Thanks Katharine!
/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit e3d9c8a into kubernetes:master Nov 5, 2019
4 of 5 checks passed
4 of 5 checks passed
tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation justaugustus authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
Release Engineering automation moved this from Review in progress to Done (1.17) Nov 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 5, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 5, 2019

@justaugustus: Updated the job-config configmap in namespace default using the following files:

  • key sig-windows-config.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-config.yaml
  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key kops-periodics.yaml using file config/jobs/kubernetes/sig-cloud-provider/aws/kops/kops-periodics.yaml
  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key gpu-gke.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gpu/gpu-gke.yaml
  • key upgrade-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/upgrade-gce.yaml
  • key upgrade-gke.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/upgrade-gke.yaml

In response to this:

This continues the pruning work I started in #15039.

Here we're doing a few things:

  • Add sig-release-generated dashboard to allow us to easily identify generated tests
  • Allow kubernetes-bazel-build jobs to fork into release dashes by moving them to *-informing
  • Drop kops and Windows jobs from job-config-errors dash
  • Drop GCE/GKE jobs from job-config-errors dash

The remaining jobs on the sig-release-job-config-errors are in config/jobs/kubernetes/sig-cli/sig-cli-config.yaml.

Several of them seem to be passing, but are incorrect named e.g., 1.12-1.13 when they're using something like stable1/stable2 markers
There are enough of them configured in confusing ways, that I'd like to tackle them in a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.