Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch integration off of kubekins-test #15144

Merged

Conversation

@BenTheElder
Copy link
Member

BenTheElder commented Nov 6, 2019

@@ -53,7 +53,7 @@ presubmits:
- name: KUBE_VERIFY_GIT_BRANCH
value: master
- name: REPO_DIR
value: /workspace/k8s.io/kubernetes
value: /home/prow/go/src/k8s.io/kubernetes

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Nov 6, 2019

Author Member

prow checks out to /home/prow/go/src/<repo> natively in pod-utils. this other path is relying on symlink hacks that will probably cause us problems.

@BenTheElder

This comment has been minimized.

Copy link
Member Author

BenTheElder commented Nov 6, 2019

/hold
I think we can drop all of these instead

@BenTheElder BenTheElder force-pushed the BenTheElder:no-more-verify-scenario-please branch from 737aeed to 6f222c3 Nov 6, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Nov 6, 2019
@BenTheElder BenTheElder changed the title set REPO_DIR correctly switch integration off of kubekins-test Nov 6, 2019
@@ -41,19 +43,11 @@ presubmits:
preset-dind-enabled: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:latest-master
imagePullPolicy: Always
- image: gcr.io/k8s-testimages/kubekins-e2e:v20191105-e60677a-master

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Nov 6, 2019

Author Member

we should go ahead and bump this, and this PR should go when we're ready to bump go

# TODO(krzyzacy): Consider combine kubekins-e2e and kubekins-test
- name: pull-kubernetes-integration-podutil
# TODO: replace the bootstrap / scenario based job going forward
- name: pull-kubernetes-integration
always_run: false

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Nov 6, 2019

Author Member

needs to be always_run

@BenTheElder BenTheElder force-pushed the BenTheElder:no-more-verify-scenario-please branch from 254085b to 41e361c Nov 6, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- name: pull-kubernetes-integration-podutil
always_run: false
# TODO: replace the bootstrap / scenario based job going forward
- name: pull-kubernetes-integration

This comment has been minimized.

Copy link
@liggitt

liggitt Nov 6, 2019

Member

I assume we'll need an identical change for ci-kubernetes-integration-master once the go bump PR merges

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Nov 6, 2019

Author Member

yes

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 6, 2019

Member

Should this job have the branching annotations? Should it also be changed for the 1.17 branch that is already cut?

This comment has been minimized.

Copy link
@liggitt

liggitt Nov 6, 2019

Member

once the bump PR merges, we'll need to update the master and 1.17 jobs

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Nov 6, 2019

Author Member

1.17 should be changed, I don't know the branching annotations yet.. but we definitely need a follow up PR to change the CI jobs as well.

This comment has been minimized.

Copy link
@cblecker
@BenTheElder BenTheElder force-pushed the BenTheElder:no-more-verify-scenario-please branch from 41e361c to 18ccef7 Nov 6, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 6, 2019
BenTheElder added 2 commits Nov 6, 2019
@BenTheElder BenTheElder force-pushed the BenTheElder:no-more-verify-scenario-please branch from 18ccef7 to 5d63ac7 Nov 6, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member Author

BenTheElder commented Nov 6, 2019

I think this is good to go once we're ready to merge all the go 1.13 things

command:
- runner.sh
args:
- ./hack/jenkins/test-dockerized.sh
env:
- name: KUBE_FORCE_VERIFY_CHECKS

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 6, 2019

Member

Why remove?

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Nov 6, 2019

Author Member

these are for verify. they have nothing to do with integration.
I tested a run with mkpj

# docker-in-docker needs privileged mode
securityContext:
privileged: true
resources:
requests:
cpu: 4
annotations:

This comment has been minimized.

Copy link
@cblecker

cblecker Nov 6, 2019

Member

Why remove?

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Nov 6, 2019

Author Member

#15144 (comment)

these annotations were for the canary job to have it's own testgrid entry as a canary, it will be in the same one as the non-master-branch job above

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Nov 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 6, 2019
@liggitt liggitt referenced this pull request Nov 6, 2019
9 of 9 tasks complete
@BenTheElder

This comment has been minimized.

Copy link
Member Author

BenTheElder commented Nov 6, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit e6c36a0 into kubernetes:master Nov 6, 2019
5 checks passed
5 checks passed
cla/linuxfoundation BenTheElder authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 6, 2019

@BenTheElder: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml

In response to this:

cc @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 6, 2019
@BenTheElder BenTheElder deleted the BenTheElder:no-more-verify-scenario-please branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.