Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip private security forks in branch protector #15207

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Nov 8, 2019

  • Move SecurityForkNameRE to github client helpers
  • Skip private security forks in branch protector
  • Fix broken "TestIgnoreArchivedRepos" test
  • Add test for "TestIgnorePrivateSecurityRepos"

/assign @BenTheElder

cblecker added 2 commits Nov 8, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Nov 8, 2019

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 8, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08fbf64 into kubernetes:master Nov 8, 2019
5 checks passed
5 checks passed
cla/linuxfoundation cblecker authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 8, 2019
@cblecker cblecker deleted the cblecker:security-is-stupid branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.