Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kubebuilder DinD runner, k8s version matrix #15346

Merged
merged 4 commits into from Nov 21, 2019

Conversation

alexeldeib
Copy link
Member

Sorta surprised the dot-slash is necessary, but I was able to run pull-kubebuiler-e2e-1-16-2 locally with pj-on-kind.sh and it works.

Now that I'm able to test these locally, I've also gone ahead and added the matrix for versions.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 21, 2019
Copy link
Member

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeldeib, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8bd3c28 into kubernetes:master Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

@alexeldeib: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubebuilder-presubmits.yaml using file config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml

In response to this:

Sorta surprised the dot-slash is necessary, but I was able to run pull-kubebuiler-e2e-1-16-2 locally with pj-on-kind.sh and it works.

Now that I'm able to test these locally, I've also gone ahead and added the matrix for versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants