Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
git: refactor to use v1 clients adapted to v2 interfaces #15364
Do you think that makes a difference? Because if something is broken we will rollback the change anyways and at that point it probably doesn't matter if the change broke everything or just one component.
It would be a different story if we had components where we don't care if they are broken temporarily but I don't think we have anything like that for git
Both for this PR and more importantly in general, I would like us to canary large changes in a single binary so we have some evidence they work correctly before refactoring the test of the code base.
It is important to design the blast radius of these types of changes. Mistakes will happen and so making the impact of the mistake as small as possible is equally important as ensuring the mistake is as infrequent as possible.
Cole and Steve, can you figure out the plan for this PR? I'm happy for you two to unhold and move this PR forward once you two have a satisfactory plan.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing