Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: introduce an interface for repository clients #15365

Merged

Conversation

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Nov 22, 2019

Signed-off-by: Steve Kuznetsov skuznets@redhat.com


depends on #15363
/assign @cjwagner @fejta @alvaroaleman

prow/git/v2/client_factory.go Show resolved Hide resolved
prow/git/v2/interactor.go Show resolved Hide resolved
prow/git/v2/interactor.go Outdated Show resolved Hide resolved
prow/git/v2/interactor.go Outdated Show resolved Hide resolved
prow/git/v2/publisher.go Show resolved Hide resolved
@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/git-v2-step-3 branch from 1d33941 to b9efafe Nov 25, 2019
@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/git-v2-step-3 branch 4 times, most recently from c9da5da to fc5a17a Nov 25, 2019
@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/git-v2-step-3 branch 3 times, most recently from d5bb7b8 to 98b9872 Dec 3, 2019
@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/git-v2-step-3 branch 3 times, most recently from cf3f6cd to efca7c9 Dec 3, 2019
@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/git-v2-step-3 branch 5 times, most recently from d44d8db to b03014f Dec 3, 2019
prow/git/v2/client_factory.go Show resolved Hide resolved
RevParse(commitlike string) (string, error)
BranchExists(branch string) bool
CheckoutNewBranch(branch string) error
Merge(commitlike string) (bool, error)

This comment has been minimized.

Copy link
@alvaroaleman

alvaroaleman Dec 4, 2019

Member

As mentioned in the original PR, I think everything that merges should be done as part of the Publisher interface so it can use the author configuration.

As an aside, what do we gain from splitting the interactor and publisher interfaces and then exposing an union interface over just exposing one interface for everything?

This comment has been minimized.

Copy link
@stevekuznetsov

stevekuznetsov Dec 4, 2019

Author Contributor

Thematic separation is all, same as for the k8s clientsets or the GitHub client

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the stevekuznetsov:skuznets/git-v2-step-3 branch from b03014f to 3fb9671 Dec 4, 2019
@stevekuznetsov

This comment has been minimized.

Copy link
Contributor Author

stevekuznetsov commented Dec 4, 2019

@cjwagner @alvaroaleman addressed comments

@alvaroaleman

This comment has been minimized.

Copy link
Member

alvaroaleman commented Dec 5, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 5, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 553ce22 into kubernetes:master Dec 5, 2019
4 of 5 checks passed
4 of 5 checks passed
tide Not mergeable. Retesting: pull-test-infra-bazel
Details
cla/linuxfoundation stevekuznetsov authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-verify-file-perms Job succeeded.
Details
pull-test-infra-yamllint Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.