Add E2E presubmit jobs for CPUManager and TopologyManager

[vpickard]

Add 2 new presubmit jobs so that we can manually
trigger CPUManager and TopologyManager E2E tests
on PRs.

Signed-off-by: vpickard vpickard@redhat.com

[k8s-ci-robot]

Welcome @vpickard!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @vpickard. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vpickard]

/cc @BenTheElder @stevekuznetsov

[BenTheElder]

/ok-to-test
/lgtm
/approve
Ideally SIG node owners to review & approve presubmits for SIG node in the future, to better spread the workload..

[vpickard]

/ok-to-test
/lgtm
/approve
Ideally SIG node owners to review & approve presubmits for SIG node in the future, to better spread the workload..

Thanks! I will definitely add them going foward to help out.

[vpickard]

/cc @derekwaynecarr

[odinuge]

Thanks for looking into this!

Just a few questions regarding instance types.

/hold
Just unhold if everything is ok! :)

[vpickard]

This is the same testgrid that is used for CPUManager CI. New tab for both the CPUManager PR job, and TopologyManager PR job. Please take a look, and let me know looks good or if you have another preference. Thanks.

[vpickard]

/hold

[vpickard]

/unhold

[odinuge]

Looks good from my perspective (ref. my previous comments)! 😄 I am not comfortable with sending this directly into master, so i'll defer a last look to @BenTheElder (approver) or someone else with more knowledge about presubmits.

Thanks for looking into this @vpickard!

/lgtm
/hold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, odinuge, vpickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-node/OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[odinuge]

/wg resource-management

[vpickard]

@klueska This one is ready for review/merge at your earliest convenience.

[BenTheElder]

/hold cancel
🙃

[k8s-ci-robot]

@vpickard: Updated the job-config configmap in namespace default at cluster default using the following files:

• key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Add 2 new presubmit jobs so that we can manually
trigger CPUManager and TopologyManager E2E tests
on PRs.

Signed-off-by: vpickard vpickard@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[odinuge]

Hi,

Still not possible to run them: kubernetes/kubernetes#86184 (comment). Am I doing something wrong, or is there something missing?

@BenTheElder

[vpickard]

Hi,

Still not possible to run them: kubernetes/kubernetes#86184 (comment). Am I doing something wrong, or is there something missing?

@BenTheElder

Same here. I do notice, that the testgrid has the new jobs, just no results. Not sure why the test is not running. Hoping @BenTheElder can help with some pointers....

https://testgrid.k8s.io/wg-resource-management#Summary

[vpickard]

Hi,
Still not possible to run them: kubernetes/kubernetes#86184 (comment). Am I doing something wrong, or is there something missing?
@BenTheElder

Same here. I do notice, that the testgrid has the new jobs, just no results. Not sure why the test is not running. Hoping @BenTheElder can help with some pointers....

https://testgrid.k8s.io/wg-resource-management#Summary

OK, the test is actually running, see here:

https://prow.k8s.io/?job=pull-kubernetes-node-kubelet-serial-topology-manager

From the slack chat, the reason we don't see this job run is because the jobs are marked as skip-reporting. Thanks @Katharine !