Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete most of the boskos/ directory from kubernetes/test-infra #17723

Merged
merged 6 commits into from
Jun 2, 2020

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented May 27, 2020

Boskos has been moved to kubernetes-sigs/boskos and is mostly operational (pending #17718).

I think we're now ready to delete most of this subdirectory from test-infra.
I left behind the update_prow_config.sh script (though it should probabyl be moved somewhere else), along with the gcp_janitor.py script. For the latter, it'd be better to use the copy from kubernetes-sigs/boskos, but #17719 makes doing that tricky, and I don't really have the proper context to fix those legacy bootstrap janitor jobs.

This PR depends on #17721, so
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 27, 2020
@k8s-ci-robot k8s-ci-robot added area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/images area/jobs area/kubetest area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 27, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2020
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy
Copy link
Member Author

ixdy commented Jun 2, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 05eeaff into kubernetes:master Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 2, 2020
@k8s-ci-robot
Copy link
Contributor

@ixdy: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Boskos has been moved to kubernetes-sigs/boskos and is mostly operational (pending #17718).

I think we're now ready to delete most of this subdirectory from test-infra.
I left behind the update_prow_config.sh script (though it should probabyl be moved somewhere else), along with the gcp_janitor.py script. For the latter, it'd be better to use the copy from kubernetes-sigs/boskos, but #17719 makes doing that tricky, and I don't really have the proper context to fix those legacy bootstrap janitor jobs.

This PR depends on #17721, so
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/images area/jobs area/kubetest area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants