Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage-migrator presubmit: use kubetest instead of kubernetes_e2e.py #20087

Merged
merged 1 commit into from Dec 2, 2020
Merged

storage-migrator presubmit: use kubetest instead of kubernetes_e2e.py #20087

merged 1 commit into from Dec 2, 2020

Conversation

roycaihw
Copy link
Member

@roycaihw roycaihw commented Dec 1, 2020

Copying

test-infra/config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml

Lines 25 to 81 in e6b167b

- name: pull-cloud-provider-azure-e2e
always_run: true
decorate: true
decoration_config:
timeout: 5h
path_alias: sigs.k8s.io/cloud-provider-azure
branches:
- master
labels:
preset-service-account: "true"
preset-azure-cred: "true"
preset-dind-enabled: "true"
extra_refs:
- org: kubernetes
repo: kubernetes
base_ref: release-1.19
path_alias: k8s.io/kubernetes
workdir: true
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20201124-be2d6d8-1.19
command:
- runner.sh
- kubetest
args:
# Generic e2e test args
- --test
- --up
- --down
- --build=quick
- --dump=$(ARTIFACTS)
# Azure-specific test args
- --provider=skeleton
- --deployment=aksengine
- --aksengine-agentpoolcount=2
- --aksengine-admin-username=azureuser
- --aksengine-creds=$(AZURE_CREDENTIALS)
- --aksengine-orchestratorRelease=1.19
- --aksengine-mastervmsize=Standard_DS2_v2
- --aksengine-agentvmsize=Standard_D4s_v3
- --aksengine-ccm
- --aksengine-cnm
- --aksengine-deploy-custom-k8s
- --aksengine-location=westus2
- --aksengine-public-key=$(AZURE_SSH_PUBLIC_KEY_FILE)
- --aksengine-template-url=https://raw.githubusercontent.com/kubernetes-sigs/cloud-provider-azure/master/tests/k8s-azure/manifest/linux.json
- --aksengine-download-url=https://aka.ms/aks-engine/aks-engine-k8s-e2e.tar.gz
# Specific test args
- --test_args=--ginkgo.focus=\[Conformance\]|\[NodeConformance\] --ginkgo.skip=\[Slow\]|\[Serial\]|\[Flaky\]
- --ginkgo-parallel=30
securityContext:
privileged: true
annotations:
testgrid-dashboards: provider-azure-cloud-provider-azure, provider-azure-presubmit
testgrid-tab-name: pr-cloud-provider-azure-e2e
description: "Run Kubernetes e2e tests for cloud-provider-azure."
testgrid-num-columns-recent: '30'
.

Trying to fix:

+ /workspace/scenarios/kubernetes_e2e.py --up --down --build=quick --check-leaked-resources --gcp-master-image=gci --gcp-node-image=gci --gcp-nodes=1 --gcp-zone=us-central1-f --provider=gce --test=false --test-cmd=../test/e2e/test-cmd.sh --timeout=50m --runtime-config=internal.apiserver.k8s.io/v1alpha1=true --env=KUBE_FEATURE_GATES=StorageVersionAPI=true,APIServerIdentity=true
usage: kubernetes_e2e.py [-h] [--env-file ENV_FILE] [--env ENV]
                         [--gce-ssh GCE_SSH] [--gce-pub GCE_PUB]
                         [--service-account SERVICE_ACCOUNT] [--build [BUILD]]
                         [--inject-bazelrc INJECT_BAZELRC]
                         [--build-federation [BUILD_FEDERATION]]
                         [--use-shared-build [USE_SHARED_BUILD]]
                         [--gcs-shared GCS_SHARED] [--cluster CLUSTER]
                         [--stage STAGE] [--test TEST] [--down DOWN] [--up UP]
                         [--tear-down-previous] [--use-logexporter]
                         [--kubetest_args KUBETEST_ARGS]
                         [--dump-before-and-after] [--aws]
                         [--aws-profile AWS_PROFILE]
                         [--aws-role-arn AWS_ROLE_ARN] [--aws-ssh AWS_SSH]
                         [--aws-pub AWS_PUB] [--aws-cred AWS_CRED]
                         [--aws-cluster-domain AWS_CLUSTER_DOMAIN]
                         [--kops-nodes KOPS_NODES]
                         [--kops-ssh-user KOPS_SSH_USER]
                         [--kops-state KOPS_STATE]
                         [--kops-state-gce KOPS_STATE_GCE]
                         [--kops-zones KOPS_ZONES] [--kops-build]
                         [--kops-multiple-zones] [--provider PROVIDER]
                         [--deployment DEPLOYMENT]
kubernetes_e2e.py: error: argument --up: expected one argument

/assign @caesarxuchao

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 1, 2020
@caesarxuchao
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit eede99a into kubernetes:master Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

@roycaihw: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kube-storage-version-migrator-presubmits.yaml using file config/jobs/kubernetes-sigs/kube-storage-version-migrator/kube-storage-version-migrator-presubmits.yaml

In response to this:

Copying

test-infra/config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml

Lines 25 to 81 in e6b167b

- name: pull-cloud-provider-azure-e2e
always_run: true
decorate: true
decoration_config:
timeout: 5h
path_alias: sigs.k8s.io/cloud-provider-azure
branches:
- master
labels:
preset-service-account: "true"
preset-azure-cred: "true"
preset-dind-enabled: "true"
extra_refs:
- org: kubernetes
repo: kubernetes
base_ref: release-1.19
path_alias: k8s.io/kubernetes
workdir: true
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20201124-be2d6d8-1.19
command:
- runner.sh
- kubetest
args:
# Generic e2e test args
- --test
- --up
- --down
- --build=quick
- --dump=$(ARTIFACTS)
# Azure-specific test args
- --provider=skeleton
- --deployment=aksengine
- --aksengine-agentpoolcount=2
- --aksengine-admin-username=azureuser
- --aksengine-creds=$(AZURE_CREDENTIALS)
- --aksengine-orchestratorRelease=1.19
- --aksengine-mastervmsize=Standard_DS2_v2
- --aksengine-agentvmsize=Standard_D4s_v3
- --aksengine-ccm
- --aksengine-cnm
- --aksengine-deploy-custom-k8s
- --aksengine-location=westus2
- --aksengine-public-key=$(AZURE_SSH_PUBLIC_KEY_FILE)
- --aksengine-template-url=https://raw.githubusercontent.com/kubernetes-sigs/cloud-provider-azure/master/tests/k8s-azure/manifest/linux.json
- --aksengine-download-url=https://aka.ms/aks-engine/aks-engine-k8s-e2e.tar.gz
# Specific test args
- --test_args=--ginkgo.focus=\[Conformance\]|\[NodeConformance\] --ginkgo.skip=\[Slow\]|\[Serial\]|\[Flaky\]
- --ginkgo-parallel=30
securityContext:
privileged: true
annotations:
testgrid-dashboards: provider-azure-cloud-provider-azure, provider-azure-presubmit
testgrid-tab-name: pr-cloud-provider-azure-e2e
description: "Run Kubernetes e2e tests for cloud-provider-azure."
testgrid-num-columns-recent: '30'
.

Trying to fix:

+ /workspace/scenarios/kubernetes_e2e.py --up --down --build=quick --check-leaked-resources --gcp-master-image=gci --gcp-node-image=gci --gcp-nodes=1 --gcp-zone=us-central1-f --provider=gce --test=false --test-cmd=../test/e2e/test-cmd.sh --timeout=50m --runtime-config=internal.apiserver.k8s.io/v1alpha1=true --env=KUBE_FEATURE_GATES=StorageVersionAPI=true,APIServerIdentity=true
usage: kubernetes_e2e.py [-h] [--env-file ENV_FILE] [--env ENV]
                        [--gce-ssh GCE_SSH] [--gce-pub GCE_PUB]
                        [--service-account SERVICE_ACCOUNT] [--build [BUILD]]
                        [--inject-bazelrc INJECT_BAZELRC]
                        [--build-federation [BUILD_FEDERATION]]
                        [--use-shared-build [USE_SHARED_BUILD]]
                        [--gcs-shared GCS_SHARED] [--cluster CLUSTER]
                        [--stage STAGE] [--test TEST] [--down DOWN] [--up UP]
                        [--tear-down-previous] [--use-logexporter]
                        [--kubetest_args KUBETEST_ARGS]
                        [--dump-before-and-after] [--aws]
                        [--aws-profile AWS_PROFILE]
                        [--aws-role-arn AWS_ROLE_ARN] [--aws-ssh AWS_SSH]
                        [--aws-pub AWS_PUB] [--aws-cred AWS_CRED]
                        [--aws-cluster-domain AWS_CLUSTER_DOMAIN]
                        [--kops-nodes KOPS_NODES]
                        [--kops-ssh-user KOPS_SSH_USER]
                        [--kops-state KOPS_STATE]
                        [--kops-state-gce KOPS_STATE_GCE]
                        [--kops-zones KOPS_ZONES] [--kops-build]
                        [--kops-multiple-zones] [--provider PROVIDER]
                        [--deployment DEPLOYMENT]
kubernetes_e2e.py: error: argument --up: expected one argument

/assign @caesarxuchao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roycaihw @caesarxuchao @k8s-ci-robot