Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: release-1.20 jobs for k/k and windows #20089

Merged
merged 1 commit into from Dec 2, 2020
Merged

azure: release-1.20 jobs for k/k and windows #20089

merged 1 commit into from Dec 2, 2020

Conversation

chewong
Copy link
Member

@chewong chewong commented Dec 2, 2020

Signed-off-by: Ernest Wong chuwon@microsoft.com

/assign @feiskyer @marosset
/hold
waiting for 1.20 kubekins-e2e image.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 2, 2020
feiskyer
feiskyer reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

justaugustus
justaugustus suggested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chewong -- You can use gcr.io/k8s-testimages/kubekins-e2e:v20201201-1941b8f-1.20 as the image for these jobs.

ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-kubekins-e2e/1333749970951475200

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
azure: release-1.20 jobs for k/k and windows
27d6a25 
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@chewong
Copy link
Member Author

chewong commented Dec 2, 2020

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@marosset
Copy link
Contributor

marosset commented Dec 2, 2020 •
edited

/lgtm

Thanks @chewong!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 756803b into kubernetes:master Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

@chewong: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.20-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.20-windows.yaml
  • key release-1.20.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.20.yaml

In response to this:

Signed-off-by: Ernest Wong chuwon@microsoft.com

/assign @feiskyer @marosset
/hold
waiting for 1.20 kubekins-e2e image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chewong chewong deleted the windows-1-20 branch December 2, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@justaugustus justaugustus justaugustus requested changes

@marosset marosset Awaiting requested review from marosset

Assignees

@justaugustus justaugustus

@feiskyer feiskyer

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chewong @k8s-ci-robot @marosset @justaugustus @feiskyer