Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup milestoneapplier for kubernetes/k8s.io #20488

Merged
merged 2 commits into from Jan 15, 2021
Merged

Setup milestoneapplier for kubernetes/k8s.io #20488

merged 2 commits into from Jan 15, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 15, 2021

Added milestones to kubernetes/k8s.io and I'd like prow to take advantage of them

/wg k8s-infra

@spiffxp
Setup milestoneapplier for k8s.io
0c4f265
@spiffxp
enable milestoneapplier for kubernetes{,-sigs} orgs
3ccc3fd 
the plugin does nothing if it has no configuration for that repo
(in the milestone_applier section)
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2021
@dims
Copy link
Member

dims commented Jan 15, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Jan 15, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 57af463 into kubernetes:master Jan 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 15, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Added milestones to kubernetes/k8s.io and I'd like prow to take advantage of them

/wg k8s-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the milestoneapplier-k8sio branch January 25, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spiffxp @dims @k8s-ci-robot