Add a unit-test for kubeadm local mode #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
pipejakob
approved these changes
Mar 17, 2017
scenarios/kubernetes_e2e_test.py
Outdated
|
|
||
| import kubernetes_e2e | ||
|
|
||
| FAKE_SCM = 'STABLE_BUILD_GIT_COMMIT 599539dc0b99976fda0f326f4ce47e93ec07217c\n' \ |
There was a problem hiding this comment.
Minor nitpick: There's a lot of information in here besides the SCM, so calling it FAKE_WORKSPACE_STATUS seems more appropriate. Same goes for fake_output_scm -> fake_output_workspace_status.
|
|
||
| FAKE_SCM = 'STABLE_BUILD_GIT_COMMIT 599539dc0b99976fda0f326f4ce47e93ec07217c\n' \ | ||
| 'STABLE_BUILD_SCM_STATUS clean\n' \ | ||
| 'STABLE_BUILD_SCM_REVISION v1.7.0-alpha.0.1320+599539dc0b9997\n' \ |
There was a problem hiding this comment.
Since you have real values here, it would be great if the test actually asserted the expected value of the SCM_REVISION that gets extracted (to make sure that the regex doesn't accidentally pick up leading/trailing whitespace, newlines, etc).
There was a problem hiding this comment.
after fighting with the bot for a while, done.
krzyzacy
force-pushed
the
kubeadm-test
branch
3 times, most recently
from
9310b9d to
c624553
Compare
|
merge to get couple runs before EoD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save some unnecessary bleeding 😫
/assign @pipejakob